Bug 1750706

Summary: vm's name could not be added into settings file
Product: Red Hat Enterprise Linux 8 Reporter: zhoujunqin <juzhou>
Component: virt-viewerAssignee: Victor Toso <victortoso>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.1CC: berrange, dblechte, tzheng, victortoso, xiaodwan
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-viewer-7.0-9.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1623756 Environment:
Last Closed: 2020-04-28 16:03:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1623756    
Bug Blocks:    

Comment 3 Victor Toso 2019-11-13 14:44:23 UTC
Issue is fixed but need to be backported. Moving to POST

Comment 5 zhoujunqin 2019-12-18 07:27:15 UTC
I can reproduce with version:
virt-viewer-7.0-8.el8.x86_64

Then try to verify this bug with new build:
virt-viewer-7.0-9.el8.x86_64

Steps:
1. Make sure there is a running guest:
# virsh dominfo spice
Id:             1
Name:           spice
UUID:           0f247bbd-ee54-4225-840e-0207402724fc
OS Type:        hvm
State:          running
...

2. Edit the virt-viewer setting file, and add uuid to the setting file, then add a comment before uuid.

Test scenario-1: Comment content doesn't contain the $guest-name string

2.1.1 
$ cat .config/virt-viewer/settings 
[virt-viewer]
ask-quit=false

#test-comment
[0f247bbd-ee54-4225-840e-0207402724fc]

2.1.2 After edit the file, use virt-viewer connect the guest
$ virt-viewer -c qemu:///system spice

2.1.3 Close virt-viewer window, and check the setting file
$ cat .config/virt-viewer/settings 
[virt-viewer]
ask-quit=false

#test-comment

#spice
[0f247bbd-ee54-4225-840e-0207402724fc]

Result: VM's name is added before its uuid successfully.

Test scenario-2: Comment content contains the $guest-name string

2.2.1
$ cat .config/virt-viewer/settings 
[virt-viewer]
ask-quit=false

#testspice
[0f247bbd-ee54-4225-840e-0207402724fc]

2.1.2 After edit the file, use virt-viewer connect the guest
$ virt-viewer -c qemu:///system spice

2.1.3 Close virt-viewer window, and check the setting file
$ cat .config/virt-viewer/settings 
[virt-viewer]
ask-quit=false

#testspice

[0f247bbd-ee54-4225-840e-0207402724fc]


Result: VM's name isn't added again, it's as expected.

So I move this bug from ON_QA to VERIFIED based on above testing.

Comment 7 errata-xmlrpc 2020-04-28 16:03:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1727