Bug 1750942

Summary: Review Request: rust-cassowary - Implementation of the Cassowary linear constraint solving algorithm
Product: [Fedora] Fedora Reporter: Artem <ego.cordatus>
Component: Package ReviewAssignee: Igor Raits <igor.raits>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: igor.raits, package-review
Target Milestone: ---Flags: igor.raits: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-11 13:32:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Artem 2019-09-10 19:55:36 UTC
Spec URL: https://atim.fedorapeople.org/for-review/rust-cassowary.spec
SRPM URL: https://atim.fedorapeople.org/for-review/rust-cassowary-0.3.0-1.fc30.src.rpm

Description:
Rust implementation of the Cassowary linear constraint solving algorithm.
The Cassowary algorithm is designed for naturally laying out user interfaces
using linear constraints, like 'this button must line up with this text box'.

Fedora Account System Username: atim

#FIXME: summary 83 symbols.

Comment 1 Igor Raits 2019-09-11 05:47:30 UTC
--- foo	2019-09-11 07:46:32.729808426 +0200
+++ rust-cassowary.spec	2019-09-08 18:16:35.452132092 +0200
@@ -7,10 +7,10 @@
 Name:           rust-%{crate}
 Version:        0.3.0
 Release:        1%{?dist}
-Summary:        Implementation of the Cassowary linear constraint solving algorithm
+Summary:        Rust implementation of the Cassowary linear constraint solving algorithm
 
 # Upstream license specification: MIT / Apache-2.0
-License:        MIT and ASL 2.0
+License:        MIT or ASL 2.0
 URL:            https://crates.io/crates/cassowary
 Source:         %{crates_source}
 
@@ -38,8 +38,8 @@
 which use "%{crate}" crate.
 
 %files          devel
-%license LICENSE-APACHE LICENSE-MIT
-%doc README.md
+%license LICENSE-MIT LICENSE-APACHE
+%doc README.md CHANGELOG.md
 %{cargo_registry}/%{crate}-%{version}/
 
 %package     -n %{name}+default-devel
@@ -58,6 +58,9 @@
 %autosetup -n %{crate}-%{version_no_tilde} -p1
 %cargo_prep
 
+%generate_buildrequires
+%cargo_generate_buildrequires
+
 %build
 %cargo_build

Comment 3 Gwyn Ciesla 2019-09-11 13:01:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cassowary