Bug 1751031 (CVE-2019-16159)

Summary: CVE-2019-16159 bird: incorrect logical expressionwhen checking the validity of an input message leads to stack-based buffer overflow
Product: [Other] Security Response Reporter: Dhananjay Arunesh <darunesh>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: bennie.joubert, ckalina, fedora, mh, msekleta, pspacek, redhat-bugzilla, skozina, thoiland
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Git HEAD Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-11 06:45:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1751032, 1751033, 1751034    
Bug Blocks:    

Description Dhananjay Arunesh 2019-09-11 04:53:56 UTC
A vulnerability was found in BIRD Internet Routing Daemon 1.6.x through 1.6.7 and 2.x through 2.0.5 has a stack-based buffer overflow. The BGP daemon's support for RFC 8203 administrative shutdown communication messages included an incorrect logical expression when checking the validity of an input message. Sending a shutdown communication with a sufficient message length causes a four-byte overflow to occur while processing the message, where two of the overflow bytes are attacker-controlled and two are fixed.

Reference:
http://trubka.network.cz/pipermail/bird-users/2019-September/013718.html
http://trubka.network.cz/pipermail/bird-users/2019-September/013720.html
http://trubka.network.cz/pipermail/bird-users/2019-September/013722.html
https://gitlab.labs.nic.cz/labs/bird/commit/1657c41c96b3c07d9265b07dd4912033ead4124b
https://gitlab.labs.nic.cz/labs/bird/commit/8388f5a7e14108a1458fea35bfbb5a453e2c563c

Comment 1 Dhananjay Arunesh 2019-09-11 04:54:20 UTC
Created bird tracking bugs for this issue:

Affects: epel-all [bug 1751033]
Affects: fedora-all [bug 1751032]


Created bird2 tracking bugs for this issue:

Affects: epel-all [bug 1751034]

Comment 2 Dhananjay Arunesh 2019-09-11 04:55:09 UTC
External References:

https://bird.network.cz/

Comment 3 Product Security DevOps Team 2019-09-11 06:45:32 UTC
This CVE Bugzilla entry is for community support informational purposes only as it does not affect a package in a commercially supported Red Hat product. Refer to the dependent bugs for status of those individual community products.

Comment 4 Toke Høiland-Jørgensen 2019-09-11 12:21:13 UTC
Note that it is *not* true that this is fixed in versions 2.0.5 and 1.6.7. The fixes are in upstream git, but not yet in a released version.


See http://trubka.network.cz/pipermail/bird-users/2019-September/013722.html - specifically:

      The bugfix patches are:
      1657c41c96b3c07d9265b07dd4912033ead4124b (1.6.x)
      8388f5a7e14108a1458fea35bfbb5a453e2c563c (2.0.x)


I'm clearing the "fixed in upstream" field, but not sure if the bug should also be reopened?