Bug 1751121

Summary:	Various JS WARNING from gnome-shell
Product:	Red Hat Enterprise Linux 7	Reporter:	Yaniv Ferszt <yferszt>
Component:	gnome-shell	Assignee:	Florian Müllner <fmuellner>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	high
Version:	7.6	CC:	casantos, fmuellner, jadahl, mboisver, mclasen, ofalk, pvlasin, rstrode, tpelka, yzheng
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	gnome-shell-3.28.3-29.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-29 20:21:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yaniv Ferszt 2019-09-11 08:44:49 UTC

Description of problem:
* Various JS WARNING from gnome-shell
on all RHEL 7.5 and 7.6 systems I see the JS warnings from gnome-shell after every boot.
8<----------8<----------8<----------
# journalctl -b | grep "JS WARNING"
Aug 09 10:10:06 HOSTNAME gnome-shell[1907]: JS WARNING: [resource:///org/gnome/shell/ui/main.js 315]: reference to undefined property "MetaStage"
Aug 09 10:10:06 HOSTNAME gnome-shell[1907]: JS WARNING: [resource:///org/gnome/shell/ui/layout.js 221]: reference to undefined property "MetaWindowGroup"
Aug 09 10:10:06 HOSTNAME gnome-shell[1907]: JS WARNING: [resource:///org/gnome/shell/ui/osdMonitorLabeler.js 59]: reference to undefined property "MetaDBusDisplayConfigSkeleton"
Aug 09 10:10:07 HOSTNAME gnome-shell[1907]: JS WARNING: [resource:///org/gnome/shell/ui/slider.js 38]: reference to undefined property "CallyActor"
Aug 09 10:10:08 HOSTNAME gnome-shell[1907]: JS WARNING: [resource:///org/gnome/shell/ui/layout.js 29]: reference to undefined property "MetaWindowX11"
Aug 09 10:10:08 HOSTNAME gnome-shell[1907]: JS WARNING: [resource:///org/gnome/shell/gdm/realmd.js 130]: reference to undefined property "_loginFormat"
Aug 09 10:10:08 HOSTNAME gnome-shell[1907]: JS WARNING: [resource:///org/gnome/shell/gdm/realmd.js 142]: reference to undefined property "_loginFormat"
8<----------8<----------8<----------

Version-Release number of selected component (if applicable):
[yf@cb-rhel7 ~]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.6 (Maipo)

[yf@cb-rhel7 ~]$ rpm -qa | grep gnome-shell
gnome-shell-3.28.3-6.el7.x86_64



How reproducible:
1) Installed OS with GUI from the RHEL 7.6 ISO

Actual results:
1) Open a terminal
2)
[yf@cb-rhel7 ~]$ journalctl -b | grep "JS WARNING"
Sep 11 09:35:07 cb-rhel7.6 gnome-shell[4157]: JS WARNING: [resource:///org/gnome/shell/ui/layout.js 29]: reference to undefined property "MetaWindowX11"
Sep 11 09:47:15 cb-rhel7.6 gnome-shell[4959]: JS WARNING: [resource:///org/gnome/shell/ui/popupMenu.js 717]: reference to undefined property "_delegate"



Expected results:
No "JS WARNING" in "journalctl -b | grep "JS WARNING""

Comment 3 Yaniv Ferszt 2019-09-11 09:43:06 UTC

System update and tested again.

[yf@cb-rhel7 ~]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.7 (Maipo)

[yf@cb-rhel7 ~]$ rpm -qa | grep gnome-shell
gnome-shell-3.28.3-11.el7.x86_64

[yf@cb-rhel7 ~]$ journalctl -b | grep "JS WARNING"
Sep 11 11:40:13 cb-rhel7.6 gnome-shell[1924]: JS WARNING: [resource:///org/gnome/shell/ui/layout.js 29]: reference to undefined property "MetaWindowX11"

RESULT:
There are still "JS WARNING's"

Comment 4 Florian Müllner 2020-05-26 18:04:00 UTC

(In reply to Yaniv Ferszt from comment #3)

> [yf@cb-rhel7 ~]$ journalctl -b | grep "JS WARNING"
> Sep 11 11:40:13 cb-rhel7.6 gnome-shell[1924]: JS WARNING:
> [resource:///org/gnome/shell/ui/layout.js 29]: reference to undefined
> property "MetaWindowX11"

This cannot be fixed in gnome-shell.

The issue is that only the "MetaWindow" type is introspected and public, but none of the subtypes that are actually used by windows ("MetaWindowX11", "MetaWindowWayland", "MetaWindowXwayland").

Either mutter needs to expose those types to introspection, or gjs needs changing to avoid the warning.

Comment 9 Florian Müllner 2020-06-09 18:34:22 UTC

*** Bug 1845490 has been marked as a duplicate of this bug. ***

Comment 10 Florian Müllner 2020-06-09 18:34:26 UTC

*** Bug 1845487 has been marked as a duplicate of this bug. ***

Comment 11 Florian Müllner 2020-06-09 18:36:31 UTC

*** Bug 1845484 has been marked as a duplicate of this bug. ***

Comment 14 Florian Müllner 2020-06-14 13:22:34 UTC

> Aug 09 10:10:08 HOSTNAME gnome-shell[1907]: JS WARNING:
> [resource:///org/gnome/shell/gdm/realmd.js 130]: reference to undefined
> property "_loginFormat"
> Aug 09 10:10:08 HOSTNAME gnome-shell[1907]: JS WARNING:
> [resource:///org/gnome/shell/gdm/realmd.js 142]: reference to undefined
> property "_loginFormat"

gnome-shell-3.28.3-28.el7 fixes those and all "regular" JS warnings that were mentioned in the bugs marked as duplicates.

However as mentioned earlier, the type of warnings that are triggered by encountering a non-introspected subtype like this one:

> Aug 09 10:10:08 HOSTNAME gnome-shell[1907]: JS WARNING:
> [resource:///org/gnome/shell/ui/layout.js 29]: reference to undefined
> property "MetaWindowX11"

cannot be addressed in gnome-shell. Some of those warnings that are mentioned in the subject were addressed in https://gitlab.gnome.org/GNOME/mutter/commit/7655e09d004ec1, but others are still present; mostly because making the types public requires code churn that's not proportional to the minor benefit (avoid a harmless warning).

Ideally gjs should be fixed to not trigger those warnings, as keeping subtypes private and expecting any manipulation to be done through API on the public parent type is perfectly legitimate.

Comment 18 Florian Müllner 2020-06-14 13:58:25 UTC

*** Bug 1845660 has been marked as a duplicate of this bug. ***

Comment 19 Michael Boisvert 2020-06-15 17:52:46 UTC

Using gnome-shell-3.28.3-28.el7 I do not see any unexpected JS warnings in the journal.

Comment 25 Michael Boisvert 2020-06-23 12:41:21 UTC

After testing gnome-shell-3.28.3-29.el7, there are no unexpected warnings in the journal.

Comment 32 errata-xmlrpc 2020-09-29 20:21:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (GNOME bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3987

Comment 34 Florian Müllner 2021-04-13 18:02:52 UTC

*** Bug 1883641 has been marked as a duplicate of this bug. ***