Bug 1752196

Are you interested in a review swap? Maybe take a look into bug #1752210.

Review swap maybe with bug #1709037.

FTBFS
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=37673990

Processing /builddir/build/BUILD/pytest-harvest-1.7.1
  Created temporary directory: /tmp/pip-req-build-df6cpr3q
  Added file:///builddir/build/BUILD/pytest-harvest-1.7.1 to build tracker '/tmp/pip-req-tracker-mgpz8ptg'
    Preparing wheel metadata: started
BUILDSTDERR:     Running command /usr/bin/python3 /usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /tmp/tmp45fn8bcq
BUILDSTDERR:     Traceback (most recent call last):
BUILDSTDERR:       File "setup.py", line 22, in <module>
BUILDSTDERR:         from setuptools_scm import get_version
BUILDSTDERR:     ModuleNotFoundError: No module named 'setuptools_scm'
BUILDSTDERR:     The above exception was the direct cause of the following exception:
BUILDSTDERR:     Traceback (most recent call last):
BUILDSTDERR:       File "/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
BUILDSTDERR:         main()
BUILDSTDERR:       File "/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
BUILDSTDERR:         json_out['return_val'] = hook(**hook_input['kwargs'])
BUILDSTDERR:       File "/usr/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 69, in prepare_metadata_for_build_wheel
BUILDSTDERR:         return hook(metadata_directory, config_settings)
BUILDSTDERR:       File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 156, in prepare_metadata_for_build_wheel
BUILDSTDERR:         self.run_setup()
BUILDSTDERR:       File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 142, in run_setup
BUILDSTDERR:         exec(compile(code, __file__, 'exec'), locals())
BUILDSTDERR:       File "setup.py", line 24, in <module>
BUILDSTDERR:         raise_from(Exception("Required packages for setup not found. Please install 'setuptools_scm'"), e)
BUILDSTDERR:       File "<string>", line 3, in raise_from
BUILDSTDERR:     Exception: Required packages for setup not found. Please install 'setuptools_scm'
:

Yep, it seems this needs the latest mock to be deployed in infra. It's supposed to happen soon.

New version:
- updated version to 1.7.2 (this is essentially just moving the patches that were already applied
                            in the rpm into the master branch.)
- fixed tests (https://github.com/smarie/python-pytest-harvest/pull/27)

Spec URL: https://in.waw.pl/~zbyszek/fedora/python-pytest-harvest.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-pytest-harvest-1.7.2-1.fc32.src.rpm

successful koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38066818

I'd be grateful for a quick review. This is blocking a bunch of other packages.

Sorry for the delay. f-r is running currently and I'll returm with new results asap.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package contains BR: python2-devel or python3-devel


===== MUST items =====

Generic:
[?]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
=> Please explain why you use BSD.

[!]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
=> Empty licensecheck.txt generated, why?

[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
=> See issue about python version.

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[?]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[!]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[?]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-pytest-harvest-1.7.2-1.fc32.noarch.rpm
          python-pytest-harvest-1.7.2-1.fc32.src.rpm
python-pytest-harvest.src: W: spelling-error %description -l en_US applicative -> application, multiplicative
python-pytest-harvest.src: W: spelling-error %description -l en_US benchmarking -> bench marking, bench-marking, benchmark
python-pytest-harvest.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 1)
2 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "de_DE.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "de_DE.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
python3-pytest-harvest.noarch: W: invalid-url URL: https://pypi.org/project/pytest-harvest/ <urlopen error [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pytest-harvest/pytest-harvest-1.7.2.tar.gz :
  CHECKSUM(SHA256) this package     : c182a64a6d51b8fb5af3cab6e53cfde18c2861e77a42f1cbe6578adc112b5163
  CHECKSUM(SHA256) upstream package : c182a64a6d51b8fb5af3cab6e53cfde18c2861e77a42f1cbe6578adc112b5163


Requires
--------
python3-pytest-harvest (rpmlib, GLIBC filtered):
    python(abi)
    python3.8dist(decopatch)
    python3.8dist(makefun)
    python3.8dist(six)



Provides
--------
python3-pytest-harvest:
    python-pytest-harvest
    python3-pytest-harvest
    python3.8dist(pytest-harvest)
    python3dist(pytest-harvest)



Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1752196
Buildroot used: fedora-rawhide-{{ target_arch }}
Active plugins: Shell-api, Python, Generic
Disabled plugins: SugarActivity, PHP, Java, R, Haskell, C/C++, fonts, Ocaml, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

> [?]: Binary eggs must be removed in %prep
>     Note: Cannot find any build in BUILD directory (--prebuilt option?)

Maybe better try to build from source instead of using pypi provides binaries only.

Hi,

this package uses the new pyproject macros
[https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/LB3GTGGWEKBT2QWOB77XQ3WXEWN4XRUK/].

> - Package contains BR: python2-devel or python3-devel

That is not needed, "BuildRequires:  pyproject-rpm-macros" pulls in the necessary
deps.

> [?]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.
> => Please explain why you use BSD.

https://pypi.org/project/pytest-harvest/ shows License: BSD License (BSD 3-Clause),
as does https://github.com/smarie/python-pytest-harvest/blob/master/LICENSE.

> [!]: License field in the package spec file matches the actual license.
>      Note: There is no build directory. Running licensecheck on vanilla
>      upstream sources. No licenses found. Please check the source files for
>      licenses manually.
> => Empty licensecheck.txt generated, why?

Some problem with fedora-review maybe? Nothing I can fix.

> [!]: A package which is used by another package via an egg interface should
>      provide egg info.

The binary package provides this:
/usr/lib/python3.7/site-packages/pytest_harvest-1.7.2.dist-info/

> [!]: Package meets the Packaging Guidelines::Python

It does, afaict. It's using the new macros to automate this, but
the end result should be correct according to the guidelines.

> [!]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.

The source tarball includes "LICENSE", and this file is also present
in the binary rpm.


(In reply to Raphael Groner from comment #9)
> > [?]: Binary eggs must be removed in %prep
> >     Note: Cannot find any build in BUILD directory (--prebuilt option?)
> 
> Maybe better try to build from source instead of using pypi provides
> binaries only.

It is built from source. It is a pure-python package, so "source" and
"binary" are pretty much the same, but fwiw, it is built from a "source"
tarball downloaded from pypi (as most python packages are...).

Thanks for explanation. Package is APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-harvest