Bug 1752751

I think if we add anything else to the VM table we need to replace one of the current columns since there's already so much information surfaced.

unfortunately we're out of time for 4.4

As mentioned in comment 3 we did hit a limit of columns that we can display on Virtual Machine screen.
However we can add the requested columns as hidden and allow user to chose which columns should be displayed.
We already offer a possibility to hide/re-order grid columns but the settings were persisted only in the local storage.

Changes:
1. add requested columns as hidden-by-default
2. server side persistence of chosen grid settings (column hiding/re-ordering)
   a) feature enabled by default
   b) existing settings are migrated (uploaded) from local storage on first login
3. add option to disable server side persistence ( header -> Options -> Persist grid settings )
   a) disabling the feature removes grid settings on the server
   b) after disabling the grid can be used as before (local storage only)
4. allow user to reset grid settings back to default values.
   a) supported settings: column width, visibility and order
   b) UI changes: a kebab button on the right side of paging controls (top right grid corner) with actions:
    1. 'Change column visibility/order' - added for consistency. Offers an alternative way of showing
       column chooser pop-up
    2. 'Reset settings'
5. bug fixes(scenarios below): 
   a) persist grid columns hidden-by-default 
   b) remove HIDDEN_WIDTH feature
   c) get user info from DB instead of session 

Bug scenario 1:  persist grid columns hidden-by-default
     
    1. show a column hidden by default (i.e. K8s Namespace column on Compute -> Virtual Machines)
    2. log out and log in again
    3. check the column visibility
    Expected result: column is visible

Bug scenario 2: remove HIDDEN_WIDTH feature

    1. hide column A (let's assume it has width 120px).
    2. swap hidden column A with some visible column B.
    3. show hidden column A
    
    Expected result:
    column A is visible in the new place and has previous width (120px)
    
    Actual result:
    column A has width equal to 1px and cannot be resized.

Bug scenario 3: get user info from DB instead of session 

    1. verify that persisting grid settings feature is enabled
    2. hide column A
    3. reload the page

    Expected result: column A is hidden
    Actual result: column A is visible (user instance stored in the session has outdated user options)

Migration scenario 1: existing options

    1. verify that user has no options
       a) via REST API [1] 
       b) DB query: select user_id, name, options::text from users
    2. verify that local storage contains settings (among them some supported settings)
    3. log in to Ovirt engine with server side grid persistence
    4. verify that:
       a) supported settings were uploaded
       b) unsupported settings were not affected


[1] http://ovirt.github.io/ovirt-engine-api-model/4.4/#services/user/methods/get

Created attachment 1719332 [details]
option to enable/disable server side persistence of grid settings

Created attachment 1719333 [details]
new columns: vCPUs and Memory

Created attachment 1719334 [details]
hiding a column via kebab button

Created attachment 1719336 [details]
reset grid settings via kebab button

Steps:
1) Do all the scenarios as per Comment 5

Results:
All scenarios successfully end in the expected result. Columns are shown or hidden as requested and options are kept and settings are stored only on server and local storage.

Verified in:
ovirt-engine-4.4.3.7-0.22.el8ev.noarch

Hi Radoslaw, 
please review the doc text for the errata and release notes: 

This enhancement enables customization of the columns displayed in theVirtual Machines table of the Administration Portal.
- Two new columns have been added to the Virtual Machines table - (number of) ‘vCPUs’, and ‘Memory (MB)’.
- A new pop-up menu has been added to the Virtual Machines table that allows you to reset the table column settings, and to add or remove columns from the display.
- The selected column display settings (column visibility and order) are now persistent on the server by default, and are migrated (uploaded) to the server. This functionality can be disabled in the User > Options popup, by de-selecting the 'Persist grid settings' option.

> Two new columns have been added to the Virtual Machines table - (number of) ‘vCPUs’, and ‘Memory (MB)’.

Please add also information that both columns are hidden by default.
The rest looks good to me.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: Red Hat Virtualization security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5179