Bug 1752951

Summary: Cleanup should confirm before starting up the cleanup process
Product: [oVirt] cockpit-ovirt Reporter: SATHEESARAN <sasundar>
Component: gluster-ansibleAssignee: Parth Dhanjal <dparth>
Status: CLOSED CURRENTRELEASE QA Contact: SATHEESARAN <sasundar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 0.13.8CC: bugs, dparth, godas, gzaidman, rhs-bugs, sabose
Target Milestone: ovirt-4.4.0Flags: sasundar: ovirt-4.4?
sasundar: planning_ack?
sasundar: devel_ack?
sasundar: testing_ack+
Target Release: 0.14.1   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.14.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1752944 Environment:
Last Closed: 2020-05-20 20:01:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1752944    

Description SATHEESARAN 2019-09-17 16:06:49 UTC 
Description of problem:
------------------------
With RHV 4.3.6 , an option to cleanup the existing gluster configuration is provided right from the cockpit deployment wizard. But when 'cleanup' button is clicked, the cleanup process immediately starts the process of removing the existing configuration. As cleanup is the 'destructive' activity, it should be confirmed before actually proceeding to the cleanup process. There are high chances that the user/customer could hit the 'cleanup' button by mistake.

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
cockpit-ovirt-dashboard-0.13.8

How reproducible:
------------------
Always

Steps to Reproduce:
--------------------
1. Complete the gluster deployment
2. Restart the gluster deployment from cockpit
3. Click on 'Clean gluster configuration' button

Actual results:
----------------
Cleanup proceeds without confirmation

Expected results:
------------------
There should be proper confirmation. Statement should be available like 'This will remove the existing gluster configuration. CONFIRM/CANCEL' kind of confirmation should be available to avoid the accidentally-hit-that-button scenario
Comment 1 Sandro Bonazzola 2020-01-23 12:20:31 UTC 
All referenced patches have been merged, can this bug move to modified?
A build including referenced patches have been issued, can this move to ON_QA?
Comment 3 SATHEESARAN 2020-03-30 14:16:22 UTC 
Tested with cockpit-ovirt-dashboard-0.14.3

While attempting for cleanup, the confirmation dialogue pops up for double-check confirmation
Comment 4 Sandro Bonazzola 2020-05-20 20:01:37 UTC 
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.