Bug 1753591

Summary: backport important flatpak fixes from 1.0.9
Product: Red Hat Enterprise Linux 7 Reporter: Kalev Lember <klember>
Component: flatpakAssignee: Kalev Lember <klember>
Status: CLOSED CURRENTRELEASE QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact:
Priority: urgent    
Version: 7.8CC: alexl, bgollahe, cww, desktop-qa-list, dking, jkoten, klember, mboisver, mclasen, tpelka
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Rebase: Bug Fixes and Enhancements
Doc Text:
Story Points: ---
Clone Of: 1748276
: 1753613 1754450 (view as bug list) Environment:
Last Closed: 2020-12-08 08:38:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1748276    
Bug Blocks: 1753613, 1754051, 1754450    

Description Kalev Lember 2019-09-19 11:22:07 UTC
Cloning this to RHEL 7 as well where the exact same reasons apply for rebasing.


+++ This bug was initially created as a clone of Bug #1748276 +++

We should update the flatpak in RHEL8 (1.0.6) to the current stable series 1.4.x

The major changes since the 1.2.x is the improved I/O use for system-installed applications, and the new format for pre-configured remotes.

--- Additional comment from Kalev Lember on 2019-09-19 11:05:12 UTC ---

It would be good to bump this up to RHEL 8.1.1. The new flatpak version has important fixes that are needed for new flatpak runtimes that are getting deployed to flathub just now.

--- Additional comment from Alexander Larsson on 2019-09-19 11:11:47 UTC ---

One important feature we want (that landed in 1.4.2) is the support for extra_data for runtime extensions (previously it was for apps only). The main usecase for this is the openh264 extension which contains the cisco-blessed openh264 decoder. We need that to use extra_data for legal (patent grant) reasons.

We're actually interested in using this particular extension for the fedora runtime too, so that e.g. a fedora-based firefox flatpak can support h264 videos.

Comment 2 Kalev Lember 2019-09-19 11:57:13 UTC
After some more irc discussion with alex and mclasen, there's a fair bit of urgency for getting the fixes out. Here's a new plan:

1) Do a Z stream update for both RHEL 7 and 8, shipping flatpak 1.0.9 (Alex Larsson is doing a 1.0.9 release just for RHEL with targeted backports). I've updated the ticket title to reflect this.

If it's necessary (if 1.0.x version updates aren't at all allowed in Z stream), we can just "fake" the 1.0.9 version (there's a server side check that makes sure the client is at least version 1.0.9) and backport the patches. I'd much prefer doing an update to 1.0.9 in Z though to make things easier and less error prone.

2) Rebase to 1.4.x for RHEL 8.1.1

Comment 3 Kalev Lember 2019-09-19 12:18:55 UTC
As per IRC discussion with jwb and others, we'd prefer updating to new 1.0.9 version in Z stream instead of doing patch backports. The reason for this is that flathub has a client version check, which checks that the flatpak client is at least version 1.0.9. We could somehow fake the version with patch backports, but it would be much, much cleaner to just update to 1.0.9 (especially since it's just important fixes backported, no ABI changes and no new features).