Bug 1753730

Summary: Enable WPE renderer
Product: [Fedora] Fedora Reporter: Michael Catanzaro <mcatanzaro>
Component: webkit2gtk3Assignee: -RETIRED- <erack>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 31CC: bunnyapocalypse, erack, gnome-sig, tpopela
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: webkit2gtk3-2.26.0-3.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-22 01:21:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Catanzaro 2019-09-19 16:27:13 UTC
We forgot to enable WPE renderer for F31. That would look like this:

diff --git a/webkit2gtk3.spec b/webkit2gtk3.spec
index ec81a42..b02c895 100644
--- a/webkit2gtk3.spec
+++ b/webkit2gtk3.spec
@@ -7,7 +7,7 @@
 
 Name:           webkit2gtk3
 Version:        2.26.0
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        GTK Web content engine library
 
 License:        LGPLv2
@@ -80,6 +80,8 @@ BuildRequires:  pkgconfig(upower-glib)
 BuildRequires:  pkgconfig(wayland-client)
 BuildRequires:  pkgconfig(wayland-egl)
 BuildRequires:  pkgconfig(wayland-server)
+BuildRequires:  pkgconfig(wpe-1.0)
+BuildRequires:  pkgconfig(wpebackend-fdo-1.0)
 BuildRequires:  pkgconfig(xt)
 
 Requires:       bubblewrap
@@ -191,7 +193,6 @@ pushd %{_target_platform}
   -DENABLE_GTKDOC=ON \
   -DENABLE_MINIBROWSER=ON \
   -DPYTHON_EXECUTABLE=%{_bindir}/python3 \
-  -DUSE_WPE_RENDERER=OFF \
   ..
 popd

Problem is that it will fail because it depends on dlopening libWPEBackend-fdo-1.0.so, which is packaged in wpebackend-fdo-devel. We need to move that to the main package as a workaround until we figure out a better solution upstream. I can't do it myself, though, because GNOME SIG doesn't have commit access to the WPE packages. Chris, can you try moving it?

Comment 1 Chris King 2019-09-19 16:40:04 UTC
Can do, I've got builds going for rawhide and 31 with this changed right now, want me to also make this change in 30 & 29?

Comment 2 Fedora Update System 2019-09-19 16:50:01 UTC
FEDORA-2019-33a35b82b6 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-33a35b82b6

Comment 3 Michael Catanzaro 2019-09-19 16:53:57 UTC
Thanks Chris. I'd leave it unchanged for F30 and F29 because it's kind of a hack and we won't be trying to use WPE renderer there.

Comment 4 Fedora Update System 2019-09-19 21:45:38 UTC
FEDORA-2019-1a46076713 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1a46076713

Comment 5 Fedora Update System 2019-09-20 02:56:55 UTC
wpebackend-fdo-1.4.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-33a35b82b6

Comment 6 Fedora Update System 2019-09-20 02:57:15 UTC
webkit2gtk3-2.26.0-3.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1a46076713

Comment 7 Fedora Update System 2019-09-22 01:21:48 UTC
wpebackend-fdo-1.4.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2019-09-22 01:22:02 UTC
webkit2gtk3-2.26.0-3.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.