Bug 1754056

Summary:	how can a package alter docker config to add a new runtime
Product:	[Fedora] Fedora	Reporter:	Cole Robinson <crobinso>
Component:	moby-engine	Assignee:	Olivier Lemasle <o.lemasle>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	34	CC:	adimania, admiller, amurdaca, dinechin, dwalsh, ichavero, jcajka, nalin, o.lemasle, santiago, stefanha
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-08 06:27:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Cole Robinson 2019-09-20 16:40:04 UTC

Sorry if this is more of a question than a bug, but...

We are working on packaging kata for Fedora. kata is an alternate OCI runtime that wraps qemu and a small appliance OS around your container.

After installing kata-runtime, podman makes it easy to test with:

  podman run --runtime=/usr/bin/kata-runtime ...'

For docker it is not so simple, it doesn't accept a path for --runtime. A runtime name=/path/to/runtime mapping needs to be configured with the daemon AFAICT. For example, on Fedora /usr/lib/systemd/system/docker.service has '--add-runtime oci=/usr/libexec/docker/docker-runc-current'

I'm trying to figure out installing kata-runtime can programmatically to the equivalent of --add-runtime kata=/usr/bin/kata-runtime for docker. Obviously editing /etc/sysconfig/docker or the unit files is not acceptable. I assume trying to drop a /etc/docker/daemon.json file isn't acceptable either, but even if it was it can't be used to add a new runtime because --add-runtime is passed on the docker daemon commandline:

Sep 20 12:36:01 localhost.localdomain dockerd-current[2724]: unable to configure the Docker daemon with file /etc/docker/daemon.json: the following directives are specified both as a flag and in the configuration file: runtimes: (from flag: [oci kata-runtime], from file: map[kata-runtime:map[path:/usr/bin/kata-runtime]]), default-runtime: (from flag: oci, from file: kata-runtime)

So any suggestions how to accomplish this? Similarly related, but is there any way to work around this in the interim without having to edit docker config files, like some way to make 'docker --runtime' work as a one off?

Comment 1 Miro Hrončok 2019-09-22 11:30:13 UTC

Automation has figured out the package is retired in Fedora 31.

If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement

Comment 2 Cole Robinson 2019-09-23 15:49:15 UTC

Moving to moby-engine. I think everything in Comment #0 still applies

Comment 3 Christophe de Dinechin 2019-09-26 13:29:40 UTC

An option would be to add an directory like /etc/sysconfig/docker-runtimes.d/ where files could specify which runtimes to run.

The kata-runtime package would simply need to add a file in that directory.

The docker.service file would need to be modified to check that directory.

Comment 4 Ben Cotton 2020-11-03 15:35:06 UTC

This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2021-02-09 15:12:37 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 6 Ben Cotton 2022-05-12 16:54:35 UTC

This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 7 Ben Cotton 2022-06-08 06:27:01 UTC

Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.

Fedora Linux 34 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release.

Thank you for reporting this bug and we are sorry it could not be fixed.