Bug 175425

Summary:	Review Request: tile - Modern versions of Tk widget set
Product:	[Fedora] Fedora	Reporter:	Wart <wart>
Component:	Package Review	Assignee:	Ignacio Vazquez-Abrams <ivazqueznet>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-23 15:30:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Wart 2005-12-10 02:17:33 UTC

Spec Name or Url: http://www.kobold.org/~wart/fedora/tile.spec
SRPM Name or Url: http://www.kobold.org/~wart/fedora/tile-0.7.2-1.src.rpm
MD5SUMs:  http://www.kobold.org/~wart/fedora/MD5SUM.asc
Description:


The Tile Widget Set is an experimental reimplementation of
some of the core Tk widgets.  This packages adds theming and
other modern features to the core Tk widget set.

Comment 1 Wart 2006-01-12 05:22:34 UTC

New package that fixes the build problems on the devel branch.

http://www.kobold.org/~wart/fedora/tile-0.7.2-2.src.rpm
http://www.kobold.org/~wart/fedora/tile.spec

Comment 2 Ignacio Vazquez-Abrams 2006-02-21 11:42:20 UTC

- Patch filename has no descriptive quality
- Odd spacing in %changelog
? Is the static lib in -devel required?
- Include demos, doc/converting.txt, and doc/html in %doc
- Install doc/*.n into %{_mandir}/mann

Comment 3 Wart 2006-02-22 22:16:51 UTC

(In reply to comment #2)
> - Patch filename has no descriptive quality

Fixed.  I also modified the patch with another minor fix for devel.

> - Odd spacing in %changelog

You mean the missing spaces between entries?  Fixed.

> ? Is the static lib in -devel required?

Yes.  This is the stub library for linking against tile.  Tcl stub libraries are
a cross-platform cross-compiler way of performing dynamic linking.  So even
though it's a static library, it's really used for dynamic linking:
http://wiki.tcl.tk/285

> - Include demos, doc/converting.txt, and doc/html in %doc

Done.

> - Install doc/*.n into %{_mandir}/mann

Done.

New files:

http://www.kobold.org/~wart/fedora/tile-0.7.2-3.src.rpm
http://www.kobold.org/~wart/fedora/tile.spec

Comment 4 Ignacio Vazquez-Abrams 2006-02-23 07:09:26 UTC

APPROVED

Comment 5 Wart 2006-02-23 15:30:35 UTC

Imported and built on devel.

Thanks!