Bug 1754468
Summary: | oc apply does not update configmap with role jenkins-slave | |||
---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Ravi Trivedi <travi> | |
Component: | Jenkins | Assignee: | Vibhav Bobade <vbobade> | |
Status: | CLOSED ERRATA | QA Contact: | XiuJuan Wang <xiuwang> | |
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 3.11.0 | CC: | abenaiss, calfonso, vbobade | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | If docs needed, set a value | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1755812 1773432 (view as bug list) | Environment: | ||
Last Closed: | 2020-06-04 07:24:16 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1773432 |
Description
Ravi Trivedi
2019-09-23 10:56:17 UTC
We are planning to release the new version of the plugin by cutting a new release of Jenkins in the coming few weeks. Wrt Openshift 4.3 we ahve already resolved the issue and would be cutting a new release for the plugin this week. https://bugzilla.redhat.com/show_bug.cgi?id=1755812 <- 4.3 @Ravi We must ask the customer to use the latest version of the plugin which will be i.e. 1.0.42 Will update it here as we are done with the release. Regards, Vibhav Triage: this is related to 3.11 , and will be fixed in 3.11.z Hello Team, I am not able to reproduce this on a 3.11 cluster and seems that the config.xml is being properly populated on oc apply without and issues. Following are the steps for reproduction I used. 1> Create ConfigMap no.1 with name testconfigmap1.yaml ``` kind: ConfigMap apiVersion: v1 metadata: name: jenkins-agent labels: role: jenkins-slave data: template1: |- <org.csanchez.jenkins.plugins.kubernetes.PodTemplate> <inheritFrom></inheritFrom> <name>template1</name> <instanceCap>2147483647</instanceCap> <idleMinutes>0</idleMinutes> <label>template1</label> <serviceAccount>jenkins</serviceAccount> <nodeSelector></nodeSelector> <volumes/> <containers> <org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate> <name>jnlp</name> <image>openshift/jenkins-agent-maven-35-centos7:v3.10</image> <privileged>false</privileged> <alwaysPullImage>true</alwaysPullImage> <workingDir>/tmp</workingDir> <command></command> <args>${computer.jnlpmac} ${computer.name}</args> <ttyEnabled>false</ttyEnabled> <resourceRequestCpu></resourceRequestCpu> <resourceRequestMemory></resourceRequestMemory> <resourceLimitCpu></resourceLimitCpu> <resourceLimitMemory></resourceLimitMemory> <envVars/> </org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate> </containers> <envVars/> <annotations/> <imagePullSecrets/> <nodeProperties/> </org.csanchez.jenkins.plugins.kubernetes.PodTemplate> ``` 2> Duplicate testconfigmap1.yaml with the following which contains a duplicate of template1 which goes by the name template2. ``` kind: ConfigMap metadata: labels: role: jenkins-slave name: jenkins-agent apiVersion: v1 data: template1: |- <org.csanchez.jenkins.plugins.kubernetes.PodTemplate> <inheritFrom></inheritFrom> <name>template1</name> <instanceCap>2147483647</instanceCap> <idleMinutes>0</idleMinutes> <label>template1</label> <serviceAccount>jenkins</serviceAccount> <nodeSelector></nodeSelector> <volumes/> <containers> <org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate> <name>jnlp</name> <image>openshift/jenkins-agent-maven-35-centos7:v3.10</image> <privileged>false</privileged> <alwaysPullImage>true</alwaysPullImage> <workingDir>/tmp</workingDir> <command></command> <args>${computer.jnlpmac} ${computer.name}</args> <ttyEnabled>false</ttyEnabled> <resourceRequestCpu></resourceRequestCpu> <resourceRequestMemory></resourceRequestMemory> <resourceLimitCpu></resourceLimitCpu> <resourceLimitMemory></resourceLimitMemory> <envVars/> </org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate> </containers> <envVars/> <annotations/> <imagePullSecrets/> <nodeProperties/> </org.csanchez.jenkins.plugins.kubernetes.PodTemplate> template2: |- <org.csanchez.jenkins.plugins.kubernetes.PodTemplate> <inheritFrom></inheritFrom> <name>template2</name> <instanceCap>2147483647</instanceCap> <idleMinutes>0</idleMinutes> <label>template2</label> <serviceAccount>jenkins</serviceAccount> <nodeSelector></nodeSelector> <volumes/> <containers> <org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate> <name>jnlp</name> <image>openshift/jenkins-agent-maven-35-centos7:v3.10</image> <privileged>false</privileged> <alwaysPullImage>true</alwaysPullImage> <workingDir>/tmp</workingDir> <command></command> <args>${computer.jnlpmac} ${computer.name}</args> <ttyEnabled>false</ttyEnabled> <resourceRequestCpu></resourceRequestCpu> <resourceRequestMemory></resourceRequestMemory> <resourceLimitCpu></resourceLimitCpu> <resourceLimitMemory></resourceLimitMemory> <envVars/> </org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate> </containers> <envVars> <envVars> <org.csanchez.jenkins.plugins.kubernetes.model.KeyValueEnvVar> <key>SOME_CACHE_FOLDER</key> <value>/dev/shm/somw_cache</value> </org.csanchez.jenkins.plugins.kubernetes.model.KeyValueEnvVar> <org.csanchez.jenkins.plugins.kubernetes.model.KeyValueEnvVar> <key>http_proxy</key> <value>proxy.proxy.proxy</value> </org.csanchez.jenkins.plugins.kubernetes.model.KeyValueEnvVar> </envVars> <annotations/> <imagePullSecrets/> <nodeProperties/> </org.csanchez.jenkins.plugins.kubernetes.PodTemplate> ``` 3> oc create -f testconfigmap1.yaml Check config.xml, template1 added to templates 4> oc apply -f testconfigmap2.yaml Check config.xml, template2 added to templates `oc get configmap jenkins-agent -o yaml` returns the correct configmap data 5> oc apply -f testconfigmap1.yaml Check config.xml, template2 removed from templates `oc get configmap jenkins-agent -o yaml` returns the correct configmap data This bug can be closed as it as already fixed as I see based on this. Let me know if I am missing anything. Regards, closing it then it has been fixed here: https://github.com/openshift/jenkins/commit/fc180707410e3e1f5b0636dc20b3ef3f18d741a5 |