Bug 1754543

Summary:	the code mirror for entering orchestration template content looses focus and doesn't repeat the character on long key press
Product:	Red Hat CloudForms Management Engine	Reporter:	Jaroslav Henner <jhenner>
Component:	UI - OPS	Assignee:	Milan Zázrivec <mzazrivec>
Status:	CLOSED ERRATA	QA Contact:	Jaroslav Henner <jhenner>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.11.0	CC:	bmidwood, dmetzger, hkataria, lavenel, mmarosi, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	AutomationBlocker, Regression, ZStream
Target Release:	5.11.9	Flags:	simaishi: cfme-5.11.z+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	5.11.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-05 22:04:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Jaroslav Henner 2019-09-23 14:02:52 UTC

Description of problem:
It is common that when focus is in the field, when user press a key on the keyboard, the character is being generated in some rate after some delay. This doesn't happen in the code-mirror used for specifying Orchestration Template

Version-Release number of selected component (if applicable):
Version 5.11.0.25.20190913144023_5682444

How reproducible:
3/3

Steps to Reproduce:
1. Service > Catalogs > Orchestration Templates > Heat Templates > Crate O.T.
2. place focus into the code mirror
3. press some key on keyboard

Actual results:
only one character is generated in the code mirror. Cursor disappears (together with the red "required" text)

Expected results:
code mirror starts filling with the pressed character


Additional info:
after putting focus again into the code mirror, all works fine

I believe this is the same problem that breaks our automation which now only places just a first character of the content it should

It is working fine on  Version 5.10.10.0.20190905201238_76e3ac6  where there is no text "required"

Comment 4 Milan Zázrivec 2020-09-15 14:11:47 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/6249

Comment 5 Milan Zázrivec 2020-09-15 14:16:10 UTC

For ivanchuk, we'll need a separate PR, since https://github.com/ManageIQ/manageiq-ui-classic/pull/6249
won't cherry-pick cleanly.

Comment 6 Milan Zázrivec 2020-09-15 15:19:03 UTC

Actually, we can cherry-pick https://github.com/ManageIQ/manageiq-ui-classic/pull/6249 into ivanchuk
cleanly, but we need to cherry-pick the following PR:

    https://github.com/ManageIQ/manageiq-ui-classic/pull/6030

first. It fixes the following bz:

    https://bugzilla.redhat.com/show_bug.cgi?id=1740753

Comment 7 CFME Bot 2020-09-30 16:56:03 UTC

New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/32443a1bb957088efb76d5a56f3cbd347a3c6b39
commit 32443a1bb957088efb76d5a56f3cbd347a3c6b39
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Sep 30 15:57:12 2019 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Sep 30 16:49:21 2020 +0000

    Merge pull request #6249 from Hyperkid123/code-editor

    Fixed lost focus on code editor after first state update.

    (cherry picked from commit fced5af06c6801519a0813bb7834b973e78d39d0)

    https://bugzilla.redhat.com/show_bug.cgi?id=1754543

 app/javascript/components/code-editor/index.js | 51 +-
 1 file changed, 24 insertions(+), 27 deletions(-)

Comment 8 Jaroslav Henner 2020-10-22 13:43:23 UTC

This is fixed.

Comment 13 errata-xmlrpc 2020-11-05 22:04:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (CloudForms 5.0.9 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4967