Bug 1754887
| Summary: | Silent failure adding kvmclock timer on non-86_64 | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux Advanced Virtualization | Reporter: | smitterl |
| Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> |
| Status: | CLOSED ERRATA | QA Contact: | smitterl |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 8.2 | CC: | dzheng, jdenemar, jtomko, lcapitulino, mprivozn, qzhang, rbalakri, smitterl, thuth, virt-maint |
| Target Milestone: | rc | Keywords: | Triaged, Upstream |
| Target Release: | 8.3 | ||
| Hardware: | All | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-6.6.0-5.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-17 17:45:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
smitterl
2019-09-24 10:02:04 UTC
Suggested patch upstream: https://www.redhat.com/archives/libvir-list/2020-July/msg01547.html Merged upstream as: 2f5d8ffebe qemu: Do not silently allow non-available timers on non-x86 systems v6.7.0-32-g2f5d8ffebe A note for QE: <timer name="kvmclock"/> will continue to be silently ignored. If I understood that correctly, without the present="yes" that <timer> tag simply means: "Give me that timer if available, otherwise just ignore it". The difference with the upstream patch is now that you should get an immediate error message when you add a <timer name="kvmclock" present="yes"/> instead of only getting an error when you try to start the guest. [root@kernelqe3 libvirt]# virsh start avocado-vt-vm1 error: Failed to start domain avocado-vt-vm1 error: unsupported configuration: Configuring the 'kvmclock' timer is not supported for virtType=kvm arch=s390x machine=s390-ccw-virtio-rhel8.2.0 guests [root@kernelqe3 libvirt]# virsh dumpxml avocado-vt-vm1 > /root/avocado-vt-vm1 [root@kernelqe3 libvirt]# virsh undefine avocado-vt-vm1 Domain avocado-vt-vm1 has been undefined [root@kernelqe3 libvirt]# virsh define /root/avocado-vt-vm1 error: Failed to define domain from /root/avocado-vt-vm1 error: unsupported configuration: Configuring the 'kvmclock' timer is not supported for virtType=kvm arch=s390x machine=s390-ccw-virtio-rhel8.2.0 guests [root@kernelqe3 libvirt]# vim /root/avocado-vt-vm1 [root@kernelqe3 libvirt]# virsh define /root/avocado-vt-vm1 Domain avocado-vt-vm1 defined from /root/avocado-vt-vm1 [root@kernelqe3 libvirt]# virsh edit avocado-vt-vm1 error: unsupported configuration: Configuring the 'kvmclock' timer is not supported for virtType=kvm arch=s390x machine=s390-ccw-virtio-rhel8.2.0 guests Failed. Try again? [y,n,i,f,?]: (In reply to smitterl from comment #10) > [root@kernelqe3 libvirt]# virsh start avocado-vt-vm1 > error: Failed to start domain avocado-vt-vm1 > error: unsupported configuration: Configuring the 'kvmclock' timer is not > supported for virtType=kvm arch=s390x machine=s390-ccw-virtio-rhel8.2.0 > guests > > [root@kernelqe3 libvirt]# virsh dumpxml avocado-vt-vm1 > > /root/avocado-vt-vm1 > [root@kernelqe3 libvirt]# virsh undefine avocado-vt-vm1 > Domain avocado-vt-vm1 has been undefined > > [root@kernelqe3 libvirt]# virsh define /root/avocado-vt-vm1 > error: Failed to define domain from /root/avocado-vt-vm1 > error: unsupported configuration: Configuring the 'kvmclock' timer is not > supported for virtType=kvm arch=s390x machine=s390-ccw-virtio-rhel8.2.0 > guests > > [root@kernelqe3 libvirt]# vim /root/avocado-vt-vm1 > [root@kernelqe3 libvirt]# virsh define /root/avocado-vt-vm1 > Domain avocado-vt-vm1 defined from /root/avocado-vt-vm1 > > [root@kernelqe3 libvirt]# virsh edit avocado-vt-vm1 > error: unsupported configuration: Configuring the 'kvmclock' timer is not > supported for virtType=kvm arch=s390x machine=s390-ccw-virtio-rhel8.2.0 > guests > Failed. Try again? [y,n,i,f,?]: Tested upstream master@8c16f81eb97bbd576a009f64f13773200171704b Upstream patch for regression test: https://www.redhat.com/archives/libvir-list/2020-September/msg00895.html Verified with: libvirt-daemon-6.6.0-5.module+el8.3.0+8092+f9e72d7e.s390x Scenario: present = yes ----------------------- # cat /root/domain.xml |grep timer <timer name="tsc" present="yes"/> # virsh define /root/domain.xml error: Failed to define domain from /root/domain.xml error: unsupported configuration: Configuring the 'tsc' timer is not supported for virtType=kvm arch=s390x machine=s390-ccw-virtio-rhel8.2.0 guests Scenario: present n/a --------------------- # cat /root/domain.xml |grep timer <timer name="tsc"/> # virsh define /root/domain.xml Domain vm2 defined from /root/domain.xml Agreed with Thomas that this is a low priority item and having unit test shouldn't be blocking. Setting VERIFIED. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:5137 |