Bug 175502 (perl-Gtk2-Spell)
| Summary: | Review Request: perl-Gtk2-Spell | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-25 22:08:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Chris Weyl
2005-12-12 00:17:15 UTC
NOTE: I cannot sponsor, but here's a review. :) Good: - Package name is good. - License is good and matches upstream (LGPL) - Source is good and matches upstream - builds fine on fc4/devel. - package seems to work as expected using the include test perl script. Minor: - rpmlint warning: W: perl-Gtk2-Spell devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.7/i386-linux-thread-multi/Gtk2/Spell/Install/gtk2spellperl.h - why bother to use the %realname macro? Is the package name expected to change very often? :) - why the 'echo n | ' in the build section? - Might include the Changelog file as a doc. Updated spec/srpm: Spec Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell.spec SRPM Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell-1.03-2.ckw.fc4.src.rpm %realname is used as I was creating a bunch of module rpms for my own use; this macro allowed me to quickly take a template spec file and cusomize it. Minor issues addressed: - 'echo n |' in %build nixed. - ChangeLog included as a doc Good: All of the above and no more rpmlint warnings TODOs: - perl is not needed as a BuildRequires - ditch the %realname macro Fixup those two remaining issues and I think this is ready for approval Updated spec/srpm: Spec Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell.spec SRPM Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell-1.03-1.ckw.fc4.src.rpm TODOs from #3 addressed; release tag reset to 1. Please remove the perl_* stuff at the very beginning of the spec. Also, please don't reset the release tag, and increment it instead even during reviews. Updated spec/srpm: Spec Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell.spec SRPM Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell-1.03-4.ckw.fc4.src.rpm Updated per #5. This package is accepted. Chris, you'll need to apply for CVS access here: https://admin.fedora.redhat.com/accounts/ In the meantime, I've imported the SRPM into CVS. Once you get CVS access, you can request a build and create any branches you'd like. Any particular reason why this package is not yet built and in owners.list ? Yes, Real World/Life issues. I'm just at the tail end of a transition from living/working in Connecticut to California; I should be back up & running by the end of the week. Assuming the movers show up with my stuff today, of course :) Remving form FE_NEEDSPONSOR tracker bug, since this is closed. |