Bug 1755120

Summary: Approve any pending CSR requests from inventory nodes is failing
Product: OpenShift Container Platform Reporter: rvanderp
Component: InstallerAssignee: Patrick Dillon <padillon>
Installer sub component: openshift-ansible QA Contact: Gaoyun Pei <gpei>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: jcallen, jialiu, rhowe, xtian
Version: 3.11.0   
Target Milestone: ---   
Target Release: 3.11.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1782858 (view as bug list) Environment:
Last Closed: 2020-01-14 05:31:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1782858    

Description rvanderp 2019-09-24 19:41:00 UTC 
Description of problem:

Version-Release number of the following components:
rpm -q openshift-ansible - openshift-ansible-3.11.104-1.git.0.379a011.el7.noarch

rpm -q ansible - ansible-2.6.17-1.el7ae.noarch

ansible --version - ansible 2.6.17

How reproducible:

Steps to Reproduce:
1. Deploy cluster
2. Nodes will fail to bootstrap
3.

Actual results:
See Task "Dump all candidate bootstrap hostnames" and beyond in attached log


Expected results:
Nodes to be able to bootstrap and have their CSRs accepted

Additional info:
Please attach logs from ansible-playbook with the -vvv flag
Comment 17 Ryan Howe 2019-12-12 02:01:00 UTC 
Created the following PR with the fix, setting undefined to null results in variables having python type list. 

https://github.com/openshift/openshift-ansible/pull/12050
Comment 19 Gaoyun Pei 2019-12-31 04:44:45 UTC 
Verify this bug using the way mentioned in Comment 14.

When one key from oo_nodes_to_config does not map to a hostvar with l_kubelet_node_name set:
TASK [Set l_nodes_to_join from node_list] ****************************************************************************************
ok: [localhost] => {"ansible_facts": {"l_nodes_to_join": "[AnsibleUndefined, u'gpei-3node-registry-router-1', u'gpei-3master-etcd-1']"}, "changed": false}

With the patch applied:
TASK [Set l_nodes_to_join from node_list] ****************************************************************************************
ok: [localhost] => {"ansible_facts": {"l_nodes_to_join": [null, "gpei-3node-registry-router-1", "gpei-3master-etcd-1"]}, "changed": false}

And no regression issue found during installation with openshift-ansible-3.11.161-1.git.0.376158f.el7.noarch.rpm.
Comment 21 errata-xmlrpc 2020-01-14 05:31:27 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0017