Bug 1755387

Summary: etckeeper in EPEL 8
Product: [Fedora] Fedora EPEL Reporter: maximilian.philipps
Component: etckeeperAssignee: Thomas Moschny <thomas.moschny>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel8CC: fedora, scott, simon, thomas.moschny
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: etckeeper-1.18.10-4.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-27 00:12:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description maximilian.philipps 2019-09-25 12:04:09 UTC
hi,
It would be nice to have etckeeper in  epel 8 like it used to be in epel 7.

Comment 1 Daniel Oetken 2019-09-26 19:40:09 UTC
Yes, this would be great to have in epel 8.

Comment 2 Fedora Update System 2019-10-03 16:04:18 UTC
FEDORA-EPEL-2019-bd4f2fa503 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-bd4f2fa503

Comment 3 Scott Sullivan 2019-10-04 00:31:05 UTC
I gave the test build a go and it has issues.

1) Fails to install due file conflict.

  Error: Transaction check error:
    file /etc/yum/pluginconf.d from install of etckeeper-1.18.10-3.el8.noarch conflicts with file from package yum-4.0.9.2-5.el8.noarch

By-passed this by installed the dependencies and then rpm -i --force <package> to move along with testing.
Note, /etc/yum/pluginconf.d is a symlink to ../dnf/plugins. This differs from Fedora.

2) Incorrect HIGHLEVEL_PACKAGE_MANAGER in etckeeper.conf

CentOS 8 is DNF based, shipped conf is set to yum.

3) Plugin doesn't actually trigger.

Looking at other DNF plugins, they seem to be packaged into python3-dnf-plugin-<plugin_name> sub-packages. 
These packages are then installing the plugins into the python site-packages structure.

So as a quick test:
  ln -s /usr/lib/yum-plugins/etckeeper.py /usr/lib/python3.6/site-packages/dnf-plugins/etckeeper.py
  [root@shinoda dnf-plugins]# yum install htop
  Failed loading plugin: etckeeper

So some debugging to do there.

Let me know if I can help further with debugging.

Comment 4 Thomas Moschny 2019-10-04 09:31:05 UTC
Thanks for testing, will look into this.

Comment 5 Fedora Update System 2019-10-04 23:17:19 UTC
etckeeper-1.18.10-3.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-bd4f2fa503

Comment 6 Fedora Update System 2019-10-05 05:58:34 UTC
FEDORA-EPEL-2019-bd4f2fa503 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-bd4f2fa503

Comment 7 Thomas Moschny 2019-10-05 05:59:36 UTC
I have updated the package, would be great if you could test the new version.

Comment 8 Scott Sullivan 2019-10-05 13:57:24 UTC
FEDORA-EPEL-2019-bd4f2fa503 / etckeeper-1.18.10-4.el8 looks good.

Testing:
Issue #1 is resolved, clean install from DNF.
Issue #2 is resolved, dnf is set as HIGHLEVEL_PACKAGE_MANAGER etckeeper.conf
Issue #3 is resolved, plugin triggers at pre and post stages of a DNF transaction.

I've also tested auto-pushing to a remote git repo with commits at pre and post transaction states.

So far, this is now working as I expect it too.

Thank you Thomas

Comment 9 Thomas Moschny 2019-10-05 15:12:30 UTC
Thanks for testing!

Comment 10 Fedora Update System 2019-10-06 02:49:49 UTC
etckeeper-1.18.10-4.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-bd4f2fa503

Comment 11 Fedora Update System 2019-10-27 00:12:15 UTC
etckeeper-1.18.10-4.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.