Bug 1755538

Summary:	Use hardening specs to build dpdk-pmdinfogen
Product:	Red Hat Enterprise Linux 8	Reporter:	Flavio Leitner <fleitner>
Component:	dpdk	Assignee:	Timothy Redaelli <tredaelli>
Status:	CLOSED ERRATA	QA Contact:	Jean-Tsung Hsiao <jhsiao>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	8.1	CC:	jhsiao, ovs-qe, tredaelli
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	dpdk-19.11-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1768405 (view as bug list)		Environment:
Last Closed:	2020-04-28 16:04:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Flavio Leitner 2019-09-25 16:09:43 UTC

Description of problem:

In the last dpdk package release, it was identified that dpdk-pmdinfogen is not built with hardening specs.

The log is here:
http://download-node-02.eng.bos.redhat.com/brewroot/packages/dpdk/18.11.2/3.el8/data/logs/x86_64/build.log

628 gcc -Wp,-MD,./.pmdinfogen.o.d.tmp -W -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations -Wold-style-definition
-Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual
-Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings
-Wdeprecated -Wimplicit-fallthrough=2 -Wno-format-truncation -g
-I/builddir/build/BUILD/dpdk-s table-18.11.2/x86_64-native-linuxapp-gcc/include
-O2 -g -pipe -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection
-Wformat -fPIC -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -pie -o pmdinfogen.o -c
/builddir/build/BUILD/dpdk-stable-18.11.2/buildtools/pmdinfogen/pmdinfogen.c
629 gcc -Wl,-z,relro -Wl,-z,now -o dpdk-pmdinfogen pmdinfogen.o


Version-Release number of selected component (if applicable):
18.11.2-3.el8

Comment 5 Jean-Tsung Hsiao 2020-01-21 15:23:22 UTC

Hi Flavio,

For regression I have run PvP 64-bytes 0-loss tests over testpmd-as-a-switch/dpdk-19.11-1 --- got 14.5 Mpps.

Any other tests need to be run for the verification.

Thanks!

Jean

Comment 6 Jean-Tsung Hsiao 2020-01-21 16:37:44 UTC

Hi Tim,

Can't find dpdk-pmdinfogen in the system:

[root@netqe24 ~]# find / -name "*pmdinfogen*"
[root@netqe24 ~]# find / -name "*pmdinfo*"
/usr/share/dpdk/usertools/dpdk-pmdinfo.py
[root@netqe24 ~]#

Am I miss someting ?
Thanks!
Jean

Comment 7 Flavio Leitner 2020-01-22 10:18:18 UTC

(In reply to Jean-Tsung Hsiao from comment #5)
> Hi Flavio,
> 
> For regression I have run PvP 64-bytes 0-loss tests over
> testpmd-as-a-switch/dpdk-19.11-1 --- got 14.5 Mpps.
> 
> Any other tests need to be run for the verification.

No, that's an errata test. We will know if it's solved in the next erratas.
Timothy, feel free to close this if you got a good errata passing.
fbl

Comment 8 Jean-Tsung Hsiao 2020-02-10 19:08:43 UTC

[root@netqe10 ~]# annocheck --debug-rpm=dpdk-devel-debuginfo-19.11-1.el8.x86_64.rpm dpdk-devel-19.11-1.el8.x86_64.rpm
annocheck: Version 8.78.
Hardened: dpdk-pmdinfogen: PASS.
[root@netqe10 ~]#

Comment 10 errata-xmlrpc 2020-04-28 16:04:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:1735

Comment 11 Red Hat Bugzilla 2023-09-14 05:43:46 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days