Bug 1755768

Summary: RFE: Support changing linux bridge options
Product: Red Hat Enterprise Linux 8 Reporter: Gris Ge <fge>
Component: NetworkManagerAssignee: Antonio Cardace <acardace>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.1CC: acardace, atragler, bgalvani, fgiudici, lrintel, pasik, rkhan, sukulkar, thaller, vbenes
Target Milestone: rcKeywords: FutureFeature, RFE
Target Release: 8.2   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: NetworkManager-1.25.1-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 01:48:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1694969    

Description Gris Ge 2019-09-26 07:53:21 UTC
Description of problem:

Allow changing linux bridge options listed in /sys/class/net/<bridge_name>/bridge/ folder.

Version-Release number of selected component (if applicable):
NetworkManager-1.20.0-3.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:

Cannot change linux bridge options via NetworkManager

Expected results:
Cannot change linux bridge options via NetworkManager

Additional info:

Runtime status query is optional as we can just ready sysfs files.

Comment 1 Thomas Haller 2019-09-26 11:42:38 UTC
which options are requested exactly?

Comment 2 Gris Ge 2020-01-20 09:59:01 UTC
(In reply to Thomas Haller from comment #1)
> which options are requested exactly?

 * group_address
 * vlan_filtering
 * vlan_protocol
 * vlan_default_pvid
 * vlan_stats_enabled
 * mcast_router
 * mcast_query_use_ifaddr
 * mcast_querier
 * mcast_hash_elasticity
 * mcast_hash_max
 * mcast_last_member_count
 * mcast_startup_query_count
 * mcast_last_member_interval
 * mcast_membership_interval
 * mcast_querier_interval
 * mcast_query_interval
 * mcast_query_response_interval
 * mcast_startup_query_interval
 * mcast_stats_enabled
 * mcast_igmp_version
 * mcast_mld_version
 * nf_call_iptables
 * nf_call_ip6tables
 * nf_call_arptables

Comment 4 Antonio Cardace 2020-03-30 15:36:00 UTC
Hi Gris, a few things:

 * mcast_hash_elasticity: this has been deprecated from Linux 5.0, I don't think it makes much sense to add it in NM.
 * gc_timer: it's a read-only param since at least Linux 2.6, same  as before I don't think it makes sense to support it for NM.

Comment 5 Gris Ge 2020-04-07 03:12:16 UTC
(In reply to Antonio Cardace from comment #4)
> Hi Gris, a few things:
> 
>  * mcast_hash_elasticity: this has been deprecated from Linux 5.0, I don't
> think it makes much sense to add it in NM.
>  * gc_timer: it's a read-only param since at least Linux 2.6, same  as
> before I don't think it makes sense to support it for NM.

Thanks for the confirmation. Just skip these two options. I will convience RHV.

Comment 10 Antonio Cardace 2020-04-27 08:31:46 UTC
Patch waiting for review https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/473.

Comment 15 Vladimir Benes 2020-07-03 11:11:44 UTC
all new options covered in test:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/595

Comment 18 errata-xmlrpc 2020-11-04 01:48:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4499