Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1756141

Summary:	New IngressController operator API field incorrectly marked optional in OpenAPI spec
Product:	OpenShift Container Platform	Reporter:	Dan Mace <dmace>
Component:	Networking	Assignee:	Dan Mace <dmace>
Networking sub component:	router	QA Contact:	Mike Fiedler <mifiedle>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	urgent
Priority:	urgent	CC:	aos-bugs, bbennett, ccoleman, deads, hongli, mifiedle
Version:	4.2.0
Target Milestone:	---
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1756132	Environment:
Last Closed:	2019-10-16 06:41:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1756132
Bug Blocks:

Description Dan Mace 2019-09-26 20:41:51 UTC

+++ This bug was initially created as a clone of Bug #1756132 +++

Description of problem:

There's a new field on the ingresscontroller API, `scope`:

https://github.com/openshift/cluster-ingress-operator/blob/release-4.2/manifests/00-custom-resource-definition.yaml#L450

The field is specified as required. This is an additive change to the v1 API, so the field _must_ be optional.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Dan Mace on 2019-09-26 20:35:41 UTC ---

I got it backwards: loadBalancer the struct is a new field that contains scope, and loadBalancer is optional (correct). loadBalancer.scope _should_ be required.

The openshift/api Go type is actually incorrect in that it marks scope optional. This needs fixed.

Due to a coincidence, the ingress operator actually ignores the +optional tag and so the CRD in 4.2 is already correct and doesn't need fixed. The generator is fixed in 4.3 and there's no reason to backport the changes yet.

Comment 1 Ben Bennett 2019-09-27 13:21:50 UTC

NOTE: This is only a change to the openshift/api repository.  The generated CRDs that are in the code are (fortunately) generated incorrectly, so there is no need to rebuild the operator.

Comment 3 Mike Fiedler 2019-09-30 13:13:57 UTC

Verified by inspection

Comment 4 errata-xmlrpc 2019-10-16 06:41:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922