Bug 1757034
| Summary: | [RFE] : sshuttle : epel8 build request | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Fabian Arrotin <fabian.arrotin> |
| Component: | sshuttle | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel8 | CC: | ben, grimbeaj, jonathan.underwood, kevin, maci, mhroncok, puiterwijk |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | sshuttle-0.78.5-8.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-06-02 00:37:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Arrotin
2019-09-30 12:34:02 UTC
Just to add that I tried a simple rebuild from f29 src.rpm and it worked fine : https://copr.fedorainfracloud.org/coprs/arrfab/not-in-epel8/build/1042568/ We need python-pytest-flake8 for the tests on the newer versions. I've requested this in https://bugzilla.redhat.com/show_bug.cgi?id=1758910 flake8 is a linter. I strongly suggest not linting upstream code in %check. https://bugzilla.redhat.com/show_bug.cgi?id=1758910 was closed as not a bug recommended that linting shouldn't be happening in a package build. Sounds like the spec file needs to be fixed. I would love to see this done as I need sshuttle on some build images I'm creating! Well, I am not meaning to run a linter here... I am just running '%{__python3} setup.py test'
I'll see about disabling the flake8 test...
Is there a pytest config that adds --flake8? No, it calls it directly in the tox.ini before it calls py.test
This appears to work:
diff -Nur sshuttle-0.78.5.orig/requirements-tests.txt sshuttle-0.78.5/requirements-tests.txt
--- sshuttle-0.78.5.orig/requirements-tests.txt 2018-10-21 14:32:43.000000000 -0700
+++ sshuttle-0.78.5/requirements-tests.txt 2020-04-05 17:35:39.091524442 -0700
@@ -2,4 +2,3 @@
pytest==3.4.2
pytest-cov==2.6.0
mock==2.0.0
-flake8==3.5.0
diff -Nur sshuttle-0.78.5.orig/setup.py sshuttle-0.78.5/setup.py
--- sshuttle-0.78.5.orig/setup.py 2018-10-21 14:32:43.000000000 -0700
+++ sshuttle-0.78.5/setup.py 2020-04-05 17:35:59.541617585 -0700
@@ -62,7 +62,6 @@
'pytest-cov',
'pytest-runner',
'mock',
- 'flake8',
],
keywords="ssh vpn",
)
diff -Nur sshuttle-0.78.5.orig/tox.ini sshuttle-0.78.5/tox.ini
--- sshuttle-0.78.5.orig/tox.ini 2018-03-16 00:33:16.000000000 -0700
+++ sshuttle-0.78.5/tox.ini 2020-04-05 17:35:26.187465663 -0700
@@ -14,8 +14,6 @@
py35: python3.5
py36: python3.6
commands =
- flake8 sshuttle --count --select=E901,E999,F821,F822,F823 --show-source --statistics
- flake8 sshuttle --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
py.test
deps =
-rrequirements-tests.txt
https://koji.fedoraproject.org/koji/taskinfo?taskID=43056487
FEDORA-EPEL-2020-93fc930e8e has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-93fc930e8e FEDORA-EPEL-2020-93fc930e8e has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-93fc930e8e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-93fc930e8e has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. |