Bug 1757117

Summary: Review Request: perl-TOML-Parser - Simple toml parser
Product: [Fedora] Fedora Reporter: Yanko Kaneti <yaneti>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-01 14:13:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yanko Kaneti 2019-09-30 15:16:11 UTC 
Spec URL: http://declera.com/~yaneti/perl-TOML-Parser/perl-TOML-Parser.spec
SRPM URL: http://declera.com/~yaneti/perl-TOML-Parser/perl-TOML-Parser-0.91-1.fc32.src.rpm
Description: Simple toml parser
Fedora Account System Username: yaneti
Comment 1 Jitka Plesnikova 2019-10-01 08:29:11 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please remove duplicity of 'perl(parent)' and add version constraint
     for 'perl(Module::Build::Tiny) >= 0.035'

$ rpm -qp --requires perl-TOML-Parser-0.91-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(constant)
      1 perl(Encode)
      1 perl(Exporter) >= 5.57
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(parent)
      1 perl(strict)
      1 perl(TOML::Parser::Tokenizer)
      1 perl(TOML::Parser::Tokenizer::Strict)
      1 perl(TOML::Parser::Util)
      1 perl(Types::Serialiser)
      1 perl(:VERSION) >= 5.10.0
      1 perl(:VERSION) >= 5.8.5
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-TOML-Parser-0.91-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(TOML::Parser) = 0.91
      1 perl-TOML-Parser = 0.91-1.fc32
      1 perl(TOML::Parser::Tokenizer)
      1 perl(TOML::Parser::Tokenizer::Strict)
      1 perl(TOML::Parser::Util)
Binary provides are Ok.

$ rpmlint ./perl-TOML-Parser*
perl-TOML-Parser.noarch: W: file-not-utf8 /usr/share/doc/perl-TOML-Parser/README.md
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
Rpmlint is ok

FIX: Remove '%clean' from spec file.  The %clean section is not required.

Please correct all 'FIX' issues.

Resolution:
Approved
Comment 2 Gwyn Ciesla 2019-10-01 13:42:56 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-TOML-Parser
Comment 3 Yanko Kaneti 2019-10-01 14:13:00 UTC 
Thanks. Fixed the FIXes. Built in rawhide