Bug 1757225

https://copr-be.cloud.fedoraproject.org/results/atim/awesome-vim-colorschemes/fedora-31-x86_64/01042943-awesome-vim-colorschemes/awesome-vim-colorschemes.spec
https://copr-be.cloud.fedoraproject.org/results/atim/awesome-vim-colorschemes/fedora-31-x86_64/01042943-awesome-vim-colorschemes/awesome-vim-colorschemes-0-4.20190921git21f5c63.fc31.src.rpm

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01059756-awesome-vim-colorschemes/awesome-vim-colorschemes.spec

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01059756-awesome-vim-colorschemes/awesome-vim-colorschemes-0-5.20190921git21f5c63.fc31.src.rpm

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-30-x86_64/01059861-awesome-vim-colorschemes/awesome-vim-colorschemes.spec

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-30-x86_64/01059861-awesome-vim-colorschemes/awesome-vim-colorschemes-0-6.20190921git21f5c63.fc30.src.rpm

 - License is unclear, please ask upstream about it, several schemes seem to be licensed as MIT, some other files are unclear about their licenses.

Filed a bug
https://github.com/rafi/awesome-vim-colorschemes/issues/12

(In reply to Robert-André Mauchin from comment #4)
>  - License is unclear, please ask upstream about it, several schemes seem to
> be licensed as MIT, some other files are unclear about their licenses.

I think that i need your help there :)
https://github.com/rafi/awesome-vim-colorschemes/issues/12#issuecomment-562930754

(In reply to Artem from comment #6)
> (In reply to Robert-André Mauchin from comment #4)
> >  - License is unclear, please ask upstream about it, several schemes seem to
> > be licensed as MIT, some other files are unclear about their licenses.
> 
> I think that i need your help there :)
> https://github.com/rafi/awesome-vim-colorschemes/issues/12#issuecomment-
> 562930754

Well for each script, try to determine the license and add it to the license list, so far i have seem MIT and CC-BY and Vim

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01126967-awesome-vim-colorschemes/awesome-vim-colorschemes.spec

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01126967-awesome-vim-colorschemes/awesome-vim-colorschemes-0-6.20191209gitb5037cb.fc31.src.rpm

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-rawhide-x86_64/01153230-awesome-vim-colorschemes/awesome-vim-colorschemes.spec

https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-rawhide-x86_64/01153230-awesome-vim-colorschemes/awesome-vim-colorschemes-0-7.20191209gitb5037cb.fc32.src.rpm

 - Remove executable bits in %prep and send a patch upstream:

awesome-vim-colorschemes.noarch: W: spurious-executable-perm /usr/share/doc/awesome-vim-colorschemes/docs/jdsimcoe-abstract.vim.md

 - Fix line encoding for:

awesome-vim-colorschemes.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/awesome-vim-colorschemes/docs/tomasr-molokai.md


Package approved, please fix the aforementioned issue before import.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License", "*No copyright* Expat
     License". 186 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/awesome-vim-
     colorschemes/review-awesome-vim-colorschemes/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/vim/vimfiles/autoload/airline(vim-devicons, vim-airline),
     /usr/share/vim/vimfiles/autoload/airline/themes(vim-airline)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 256000 bytes in 60 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: awesome-vim-colorschemes-0-7.20191209gitb5037cb.fc32.noarch.rpm
          awesome-vim-colorschemes-0-7.20191209gitb5037cb.fc32.src.rpm
awesome-vim-colorschemes.noarch: W: spurious-executable-perm /usr/share/doc/awesome-vim-colorschemes/docs/jdsimcoe-abstract.vim.md
awesome-vim-colorschemes.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/awesome-vim-colorschemes/docs/tomasr-molokai.md
awesome-vim-colorschemes.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/awesome-vim-colorschemes

FEDORA-2020-ca1f061f9b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ca1f061f9b

awesome-vim-colorschemes-0-8.20191209gitb5037cb.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7b4ce8dc2b

awesome-vim-colorschemes-0-8.20191209gitb5037cb.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-2ff0d1d3ff

awesome-vim-colorschemes-0-8.20191209gitb5037cb.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ca1f061f9b

awesome-vim-colorschemes-0-8.20191209gitb5037cb.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

awesome-vim-colorschemes-0-8.20191209gitb5037cb.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

awesome-vim-colorschemes-0-8.20191209gitb5037cb.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.