Bug 1757570

Summary: [Upgrade] 13z7 -> 13z8 failed with error: "No variable found with this name: Controller_pre_deployments"
Product: Red Hat OpenStack Reporter: Yogev Rabl <yrabl>
Component: openstack-tripleo-heat-templatesAssignee: RHOS Maint <rhos-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Lukas Bezdicka <lbezdick>
Severity: high Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: akaris, aschultz, chris.brown, cswanson, dhill, emacchi, fsoppels, jfrancoa, jmelvin, lbezdick, ljozsa, mburns, mgarciac, michele, mircea.vutcovici, pveiga, rcarrier, rhos-maint, rlondhe, rsunog, shtiwari, tkajinam, tvignaud, whayutin, ykulkarn
Target Milestone: ---Keywords: TestOnly, Triaged, ZStream
Target Release: ---Flags: emacchi: needinfo+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-8.4.1-25.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-11 10:36:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Mistral ansible playbooks directory none

Description Yogev Rabl 2019-10-01 20:06:01 UTC
Created attachment 1621548 [details]
Mistral ansible playbooks directory

Description of problem:
The upgrade of the overcloud failed when running the /var/lib/mistral/211b42b4-a6d9-43a8-a558-5a8983265d72/deploy_steps_playbook.yaml playbook, in task: 

- hosts: Controller:overcloud
  name: Server deployments
  gather_facts: no
  any_errors_fatal: yes
  tasks:
    - include_tasks: deployments.yaml
      vars:
        force: false
      with_items: "{{ lookup('vars', tripleo_role_name + '_pre_deployments')|default([]) }}"
  tags:
    - overcloud
    - pre_deploy_steps

When running the command openstack overcloud upgrade run --nodes Controller.

TripleO fails to gather the right variables. The printed messages are:
TASK [tripleo-ssh-known-hosts : In-place update of /etc/ssh_known_hosts] *******
Tuesday 01 October 2019  14:33:06 -0400 (0:00:02.061)       0:00:15.501 ******* 
changed: [controller-2] => {"changed": true, "cmd": "cat '/tmp/ansible.AnwEMv' > /etc/ssh/ssh_known_hosts\n rm -f '/tmp/ansible.AnwEMv'", "delta": "0:00:00.007342", "end": "2019-10-01 18:33:06.340313", "rc": 0, "start": "2019-10-01 18:33:06.332971", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
changed: [controller-1] => {"changed": true, "cmd": "cat '/tmp/ansible.dD2xQY' > /etc/ssh/ssh_known_hosts\n rm -f '/tmp/ansible.dD2xQY'", "delta": "0:00:00.007092", "end": "2019-10-01 18:33:06.495563", "rc": 0, "start": "2019-10-01 18:33:06.488471", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
changed: [controller-0] => {"changed": true, "cmd": "cat '/tmp/ansible.XjXKuF' > /etc/ssh/ssh_known_hosts\n rm -f '/tmp/ansible.XjXKuF'", "delta": "0:00:00.006474", "end": "2019-10-01 18:33:06.622150", "rc": 0, "start": "2019-10-01 18:33:06.615676", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

PLAY [Server deployments] ******************************************************

TASK [include_tasks] ***********************************************************
Tuesday 01 October 2019  14:33:06 -0400 (0:00:00.709)       0:00:16.211 ******* 
fatal: [controller-2]: FAILED! => {"msg": "No variable found with this name: Controller_pre_deployments"}
fatal: [controller-1]: FAILED! => {"msg": "No variable found with this name: Controller_pre_deployments"}
fatal: [controller-0]: FAILED! => {"msg": "No variable found with this name: Controller_pre_deployments"}


The ansible playbook directory is attached

Version-Release number of selected component (if applicable):
openstack-tripleo-common-containers-8.6.8-16.el7ost.noarch
openstack-tripleo-common-8.6.8-16.el7ost.noarch

How reproducible:
Happen 2 with similar configuration

Steps to Reproduce:
1. Deploy OSP 12
2. Upgrade to osp 13

Comment 8 Christopher Brown 2019-11-18 18:41:22 UTC
Looks like this backport was incorrectly abandonded:

https://review.opendev.org/#/c/690048/

Comment 11 Emilien Macchi 2019-11-29 14:57:57 UTC
(In reply to Christopher Brown from comment #8)
> Looks like this backport was incorrectly abandonded:
> 
> https://review.opendev.org/#/c/690048/

Wrong, the backport was merged here: https://review.opendev.org/#/c/680728/

Comment 33 Lon Hohberger 2020-03-11 10:36:27 UTC
According to our records, this should be resolved by openstack-tripleo-heat-templates-8.4.1-42.el7ost.  This build is available now.