Bug 1758067

Summary:	RFE: Add Missing Host statistics
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Ori Liel <oliel>
Component:	vdsm	Assignee:	Marcin Sobczyk <msobczyk>
Status:	CLOSED WONTFIX	QA Contact:	meital avital <mavital>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	lsurette, michal.skrivanek, mperina, srevivo, ycui
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-10 07:24:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1751423

Description Ori Liel 2019-10-03 07:58:54 UTC

The following host statistics are not fetched by VDSM: 

  memory.buffers
  memory.cached
  swap.cached

This causes a bug in oVirt, where these statistics are displayed as having the value 0: 

  https://bugzilla.redhat.com/1751423

VDSM should collect and return these statistics.

Comment 1 Michal Skrivanek 2019-10-04 05:25:45 UTC

Why is this filed as RHV bug?

These statistics are not displayed, AFACT. 
Why do we want to collect these, oVirt doesn’t use these values directly?

Comment 2 Ori Liel 2019-10-10 05:57:22 UTC

It's a RHV bug because when fetching host statistics

  GET .../ovirt-engine/api/hosts/xxx 

these metrics are reported as having the value '0', regardless of their true value:


    <statistic href="/ovirt-engine/api/hosts/7d74774b-6bb1-45df-a7be-f855e02a9dd5/statistics/c81c86f0-bc61-3c78-a543-898b8339d03f" id="c81c86f0-bc61-3c78-a543-898b8339d03f">
        <name>memory.buffers</name>
        <description>IO buffers</description>
        <kind>gauge</kind>
        <type>integer</type>
        <unit>bytes</unit>
        <values>
            <value>
                <datum>0</datum>                    <------------ HERE
            </value>
        </values>
        <host href="/ovirt-engine/api/hosts/7d74774b-6bb1-45df-a7be-f855e02a9dd5" id="7d74774b-6bb1-45df-a7be-f855e02a9dd5"/>
    </statistic>
    <statistic href="/ovirt-engine/api/hosts/7d74774b-6bb1-45df-a7be-f855e02a9dd5/statistics/1b6244ee-8dbd-365d-8762-482ddc05ee11" id="1b6244ee-8dbd-365d-8762-482ddc05ee11">
        <name>memory.cached</name>
        <description>OS caches</description>
        <kind>gauge</kind>
        <type>integer</type>
        <unit>bytes</unit>
        <values>
            <value>
                <datum>0</datum>                    <------------ HERE
            </value>
        </values>
        <host href="/ovirt-engine/api/hosts/7d74774b-6bb1-45df-a7be-f855e02a9dd5" id="7d74774b-6bb1-45df-a7be-f855e02a9dd5"/>
    </statistic>
    <statistic href="/ovirt-engine/api/hosts/7d74774b-6bb1-45df-a7be-f855e02a9dd5/statistics/ea00da15-de2d-3393-a7cb-810c4b19ed07" id="ea00da15-de2d-3393-a7cb-810c4b19ed07">
        <name>swap.cached</name>
        <description>Swap also in memory</description>
        <kind>gauge</kind>
        <type>integer</type>
        <unit>bytes</unit>
        <values>
            <value>
                <datum>0</datum>                    <------------ HERE
            </value>
        </values>
        <host href="/ovirt-engine/api/hosts/7d74774b-6bb1-45df-a7be-f855e02a9dd5" id="7d74774b-6bb1-45df-a7be-f855e02a9dd5"/>
    </statistic>

Comment 3 Martin Perina 2019-10-10 07:24:49 UTC

Upon further discussion closing as WONTFIX, it was decided in the past that all metrics which are not used by engine itself should be published only into the metrics store.