Bug 1758380
| Summary: | Review Request: cawbird - Fork of the Corebird GTK Twitter client that continues to work with Twitter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Artem <ego.cordatus> |
| Component: | Package Review | Assignee: | Vitaly <vitaly> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, vitaly |
| Target Milestone: | --- | Flags: | vitaly:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-10-15 22:39:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Artem
2019-10-04 00:33:53 UTC
https://copr-be.cloud.fedoraproject.org/results/atim/cawbird/fedora-31-x86_64/01045445-cawbird/cawbird.spec https://copr-be.cloud.fedoraproject.org/results/atim/cawbird/fedora-31-x86_64/01045445-cawbird/cawbird-1.0.1-2.20191002git870f127.fc31.src.rpm https://copr-be.cloud.fedoraproject.org/results/atim/cawbird/fedora-31-x86_64/01049060-cawbird/cawbird.spec https://copr-be.cloud.fedoraproject.org/results/atim/cawbird/fedora-31-x86_64/01049060-cawbird/cawbird-1.0.2-1.fc31.src.rpm I will review this package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/es_419, /usr/share/locale/es_419/LC_MESSAGES [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/es_419, /usr/share/locale/es_419/LC_MESSAGES [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cawbird-1.0.2-1.fc32.x86_64.rpm cawbird-debuginfo-1.0.2-1.fc32.x86_64.rpm cawbird-debugsource-1.0.2-1.fc32.x86_64.rpm cawbird-1.0.2-1.fc32.src.rpm cawbird.x86_64: E: incorrect-locale-subdir /usr/share/locale/es_419/LC_MESSAGES/cawbird.mo cawbird.x86_64: E: invalid-lc-messages-dir /usr/share/locale/es_419/LC_MESSAGES/cawbird.mo 4 packages and 0 specfiles checked; 2 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: cawbird-debuginfo-1.0.2-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). cawbird.x86_64: W: invalid-url URL: https://github.com/IBBoard/cawbird <urlopen error [Errno -2] Name or service not known> cawbird.x86_64: E: incorrect-locale-subdir /usr/share/locale/es_419/LC_MESSAGES/cawbird.mo cawbird.x86_64: E: invalid-lc-messages-dir /usr/share/locale/es_419/LC_MESSAGES/cawbird.mo cawbird-debuginfo.x86_64: W: invalid-url URL: https://github.com/IBBoard/cawbird <urlopen error [Errno -2] Name or service not known> cawbird-debugsource.x86_64: W: invalid-url URL: https://github.com/IBBoard/cawbird <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 2 errors, 3 warnings. Source checksums ---------------- https://github.com/IBBoard/cawbird/archive/v1.0.2/cawbird-1.0.2.tar.gz : CHECKSUM(SHA256) this package : 7aff08065d2581b6c79559d592e4d4967845739589f66fda55de35c1a802cd44 CHECKSUM(SHA256) upstream package : 7aff08065d2581b6c79559d592e4d4967845739589f66fda55de35c1a802cd44 Requires -------- cawbird (rpmlib, GLIBC filtered): dbus-common hicolor-icon-theme libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgspell-1.so.2()(64bit) libgstreamer-1.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libsoup-2.4.so.1()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH) cawbird-debuginfo (rpmlib, GLIBC filtered): cawbird-debugsource (rpmlib, GLIBC filtered): Provides -------- cawbird: application() application(uk.co.ibboard.cawbird.desktop) cawbird cawbird(x86-64) metainfo() metainfo(uk.co.ibboard.cawbird.appdata.xml) cawbird-debuginfo: cawbird-debuginfo cawbird-debuginfo(x86-64) debuginfo(build-id) cawbird-debugsource: cawbird-debugsource cawbird-debugsource(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1758380 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Shell-api, C/C++, Generic Disabled plugins: Python, R, fonts, Perl, Haskell, Java, Ocaml, SugarActivity, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH 1. Please add BuildRequires: gcc. 2. File bug report against this: "E: invalid-lc-messages-dir /usr/share/locale/es_419/LC_MESSAGES". I think this minor issues can be fixed during import to Fedora SCM. Package approved. https://copr-be.cloud.fedoraproject.org/results/atim/cawbird/fedora-31-x86_64/01049179-cawbird/cawbird.spec https://copr-be.cloud.fedoraproject.org/results/atim/cawbird/fedora-31-x86_64/01049179-cawbird/cawbird-1.0.2-2.fc31.src.rpm (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cawbird FEDORA-2019-5d4bbac59a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5d4bbac59a FEDORA-2019-3c301199bc has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3c301199bc cawbird-1.0.2-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3c301199bc cawbird-1.0.2-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5d4bbac59a cawbird-1.0.2-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. cawbird-1.0.2-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |