Bug 1758687

Summary:	[DR] etcd-member-recover.sh: tokenization can fail silently
Product:	OpenShift Container Platform	Reporter:	Sam Batschelet <sbatsche>
Component:	Etcd	Assignee:	Sam Batschelet <sbatsche>
Status:	CLOSED ERRATA	QA Contact:	ge liu <geliu>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.3.0	CC:	ccoleman, scuppett, skolicha
Target Milestone:	---
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-13 21:26:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sam Batschelet 2019-10-04 20:53:03 UTC

Description of problem: tokenization[1] can fail[2][3][4] without error.

[1]: https://github.com/openshift/machine-config-operator/blob/b135a37d0e380c904fe5397b68a71a3bf33a10ba/templates/master/00-master/_base/files/usr-local-bin-etcd-member-recover-sh.yaml#L71

[2]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-disruptive-4.3/3/build-log.txt

[3]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-disruptive-4.3/3/artifacts/e2e-aws-disruptive/pods/openshift-etcd_etcd-member-ip-10-0-142-1.ec2.internal_certs.log

[4]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-disruptive-4.3/3/artifacts/e2e-aws-disruptive/pods/openshift-etcd_etcd-member-ip-10-0-142-1.ec2.internal_certs_previous.log

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:

If tokenization fails exit non 0 and print error.


Additional info:

Comment 2 ge liu 2019-11-18 09:53:44 UTC

@Sam Batschelet, I'm confuse somewhat, log[2][3][4] have error msg already, then why we still need exit with non 0 and print err?

Comment 3 ge liu 2019-11-26 10:02:10 UTC

Hi Sam, it there any update? thx

Comment 5 Michal Fojtik 2019-12-13 12:51:06 UTC

*** Bug 1758681 has been marked as a duplicate of this bug. ***

Comment 6 ge liu 2019-12-18 06:02:03 UTC

Thank you Suresh.

Comment 8 errata-xmlrpc 2020-05-13 21:26:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062