Bug 175898 (perl-Text-CSV_XS)
| Summary: | Review Request: perl-Text-CSV_XS - Comma-separated values manipulation routines | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
| Component: | Package Review | Assignee: | Paul Howarth <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cweyl, fedora-extras-list, kasal, kevin, mmaslano, xavier |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-03 15:44:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 175899 | ||
|
Description
Jose Pedro Oliveira
2005-12-16 00:19:22 UTC
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 (i386) and in mock for rawhide (i386)
- no explicit BR's needed nor present
- no locales, libraries, pkgconfigs, or subpackages to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets
Suggestion:
- The compiler flags are specified twice:
CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
It'd be slightly neater to do it just once:
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
Just a cosmetic thing really though.
Approved.
Paul, * RPM_OPT_FLAGS: specfile updated (and my specfile generator script). * Imported and build for FC-4 and devel. Thanks, jpo Package Change Request ====================== Package Name: perl-Text-CSV_XS New Branches: EL-4 EL-5 Package Change Request ====================== Package Name: perl-Text-CSV_XS New Branches: EL-4 EL-5 Updated EPEL Owners: kasal xavierb Updated EPEL CC: perl-sig Can you guys coordinate here? Marcela and Štěpán are listed as co-owners of the fedora package. Do all 3 of you want to maintain for EPEL? Not sure what Stepan and Marcela really want. I and Chris Weyl separately asked to have this package for EPEL (RHBZ 441646 and 237025). Since the bug I opened wasn't moving after some time, I offered to do the build myself or even co-maintain. Marcela answered me to either take ownership or comaintain. I'd rather co-maintain. As the EPEL owners weren't specified in the first branch request, I updated it with the primary owner and myself. I don't know if it was the proper way to deal with the issue, nor do I know exactly what Stepan and Marcela want to do. I added everyone involved to the CC: so everyone can comment. Setting fedora-review flag properly so this doesn't show up in the "to-be-reviewed" list. Stepan, Marcela, could you please comment ? Chris, if you wish too... Sorry for the delay here... I just copied over all the maintainers/co-maintainers/cc's to the epel branches and added Xavier as a co-maintainer of them. Hope that works for everyone. Built for EL-4 and EL-5. |