Bug 1759062
| Summary: | Port IMS Workflow - Regressions | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Fabien Dupont <fdupont> | |
| Component: | V2V | Assignee: | Fabien Dupont <fdupont> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shveta <sshveta> | |
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | |
| Priority: | high | |||
| Version: | 5.11.0 | CC: | bthurber, dmetzger, mshriver, mturley, mzazrivec | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.12.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1789433 (view as bug list) | Environment: | ||
| Last Closed: | 2020-10-26 16:13:49 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Bug | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | V2V | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1740510, 1789433 | |||
|
Description
Fabien Dupont
2019-10-07 10:24:48 UTC
Remove handover from shutdown_vm transition https://github.com/ManageIQ/manageiq/pull/19371 Extend InfraConversionJob timeout https://github.com/ManageIQ/manageiq/pull/19373 Fix progress percentage calculation https://github.com/ManageIQ/manageiq/pull/19375 Related UI issues: https://github.com/ManageIQ/manageiq-v2v/issues/1045 https://github.com/ManageIQ/manageiq-v2v/issues/1046 PR to fix issue #1046: https://github.com/ManageIQ/manageiq-v2v/pull/1049 PR to fix issue #1045: https://github.com/ManageIQ/manageiq-v2v/pull/1055 Also, I opened another issue to follow up on when the status message strings are finalized, since we will need to update the UI's strings to match. https://github.com/ManageIQ/manageiq-v2v/issues/1054 Fabien, if you let me know when those are final, I will follow up with a final PR to close #1054. @Mike, I think we're ready. CFME 5.11.1 builds have started and these BZs/PRs should get in. What's the status of https://github.com/ManageIQ/manageiq-v2v/issues/1054 ? @Fabien, I left #1054 open just to remind us to go back and make sure the new migration status messages get translated, but I was waiting for confirmation that we have them all finalized. Are these the final messages? https://github.com/ManageIQ/manageiq/blob/master/app/models/infra_conversion_job.rb#L76-L128 Also, Milan had expressed that he thinks the API should return already-translated strings here and the UI shouldn't have to do it. But perhaps that is out of scope here. I'll let him comment on that. Yes, issue 1054 needs to be fixed on backend side, but I haven't got around to fix it yet. Fabien, if we're in a hurry to resolve this BZ before Milan has a chance to fix #1054, I think it would be okay to open a separate BZ for updating the translations of those strings. If we backport https://github.com/ManageIQ/manageiq-v2v/pull/1055 the strings will work fine in English, since an unknown string will just skip translation. Fabien, we've merged https://github.com/ManageIQ/manageiq-v2v/pull/1076 to bring the new backend strings into the UI, but I'm not sure if what I used there is actually the latest list of strings, can you check it out when you get a chance? LGTM. I needed we'll adjust later, but the workflow is merged, so the states messages shouldn't change. We are good with this PR and this also closes the workflow refactor. Moving to POST for inclusion in 5.11.2. |