Bug 1759179

Summary: Please do not filter glassfish-el
Product: [Fedora] Fedora Modules Reporter: Mat Booth <mat.booth>
Component: mavenAssignee: Mikolaj Izdebski <mizdebsk>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: mhroncok, mizdebsk, zbyszek
Target Milestone: ---Keywords: FutureFeature, Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: maven-3.5-2920191030080639.868ae023 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-14 06:58:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1759176    
Attachments:
Description Flags
Proposed patch none

Description Mat Booth 2019-10-07 14:37:17 UTC
In the maven module, glassfish-el is filtered [1] but not glassfish-el-api subpackage:

https://src.fedoraproject.org/modules/maven/blob/3.5/f/maven.yaml#_39

Because Eclipse requires both glassfish-el and glassfish-el-api, but glassfish-el is not available from maven, I tried to include the package in the Eclipse module, but that causes bug 1759176

And obviously I can't recommend users disable all their Java modules to install dangerously out-of-date ursine packages.

My ideal solution is to make eclipse:latest a default module stream so that users get all the correct packages from the modules, but apparently default modules are not allowed to ship duplicate packages.

Please consider removing glassfish-el from the filter list of maven:3.5 -- this will enable me to drop glassfish-el from the Eclipse module, and that should allow me to make Eclipse a default module, which should fix the upgrade path from ursine to modular Eclipse.

Comment 1 Miro HronĨok 2019-10-07 17:55:31 UTC
BTW The dangerously out-of-date ursine packages seem to be at the same version as the modular ones, at least when it comes to glassfish-el.

Comment 2 Mikolaj Izdebski 2019-10-08 12:02:37 UTC
Maven 3.6 already dropped glassfish-el, so I am going to backport this change to 3.5 stream too.
But I'm blocked by a few external things:
- javapackages module branches are marked as EOL in PDC, so I can't commit to them - I have asked Release Engineering to update component branch SLA in ticket https://pagure.io/releng/issue/8877
- I don't have commit ACL on some dist-git repos - I have asked maintainer to grant me commit ACL in ticket https://pagure.io/stewardship-sig/issue/53

Comment 3 Mikolaj Izdebski 2019-10-09 06:59:13 UTC
maven 3.5 stream branch is marked as inactive in PDC, I will need to request its re-activation.

Comment 4 Mikolaj Izdebski 2019-10-09 07:00:13 UTC
Created attachment 1623730 [details]
Proposed patch

Comment 5 Mat Booth 2019-10-10 13:15:55 UTC
(In reply to Mikolaj Izdebski from comment #3)
> maven 3.5 stream branch is marked as inactive in PDC, I will need to request
> its re-activation.

The releng bug was resolved so I applied the patch. However I could not attempt a build:

$ fedpkg module-build
Submitting the module build...
Could not execute module_build: The build failed with:
None of the base module (platform or bootstrap) streams in the buildrequires section could be found


I assume this is because F28 it no longer a valid platform on which to build since its retirement.

Comment 6 Mikolaj Izdebski 2019-10-16 07:01:18 UTC
maven:3.5 module was switched to build-depend on platform:f29

Comment 7 Mikolaj Izdebski 2019-10-22 06:27:12 UTC
Resolution of this issue is blocked by releng ticket: https://pagure.io/releng/issue/8909

Comment 8 Mikolaj Izdebski 2019-10-30 10:19:42 UTC
Module build #6921 is complete.
Bodhi updates are blocked on infra issue https://pagure.io/fedora-infrastructure/issue/8336

Comment 10 Mikolaj Izdebski 2019-11-12 13:20:04 UTC
Pushing update to stable is blocked on Bodhi issue https://github.com/fedora-infra/bodhi/issues/3708

Comment 11 Fedora Update System 2019-11-13 11:44:30 UTC
maven-3.5-2920191030094746.868ae023 has been pushed to the Fedora 31 Modular stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2019-11-14 02:16:53 UTC
maven-3.5-2920191030094641.868ae023 has been pushed to the Fedora 29 Modular stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2019-11-14 02:21:35 UTC
maven-3.5-2920191030094717.868ae023 has been pushed to the Fedora 30 Modular stable repository. If problems still persist, please make note of it in this bug report.