Bug 1760791

Summary:	afr: support split-brain CLI for replica 3
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1756938	Environment:
Last Closed:	2019-11-13 05:04:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1756938, 1760792
Bug Blocks:	1759875

Description Ravishankar N 2019-10-11 10:42:26 UTC

+++ This bug was initially created as a clone of Bug #1756938 +++

Description of problem:

Ever since we added quorum checks for lookups in afr via commit
bd44d59741bb8c0f5d7a62c5b1094179dd0ce8a4, the split-brain resolution
commands would not work for replica 3 because there would be no
readables for the lookup fop.

The argument was that split-brains do not occur in replica 3 but we do
see (data/metadata) split-brain cases once in a while which indicate that  there are   a few bugs/corner cases yet to be discovered and fixed.

Fortunately, commit  8016d51a3bbd410b0b927ed66be50a09574b7982 added
GF_CLIENT_PID_GLFS_HEALD as the pid for all fops made by glfsheal. If we
leverage this and allow lookups when pid is GF_CLIENT_PID_GLFS_HEALD,
split-brain resolution commands will work for replica 3 volumes too.

Attempting a patch which does this.

--- Additional comment from Worker Ant on 2019-09-30 09:15:59 UTC ---

REVIEW: https://review.gluster.org/23502 (afr: support split-brain CLI for replica 3) posted (#1) for review on master by Ravishankar N

--- Additional comment from Worker Ant on 2019-10-09 06:36:39 UTC ---

REVIEW: https://review.gluster.org/23502 (afr: support split-brain CLI for replica 3) merged (#5) on master by Krutika Dhananjay

Comment 1 Worker Ant 2019-10-11 10:44:50 UTC

REVIEW: https://review.gluster.org/23544 (afr: support split-brain CLI for replica 3) posted (#1) for review on release-7 by Ravishankar N

Comment 2 Worker Ant 2019-11-13 05:04:38 UTC

REVIEW: https://review.gluster.org/23544 (afr: support split-brain CLI for replica 3) merged (#2) on release-7 by hari gowtham