Bug 1761548

Summary:	Persistent Volumes with `Delete` reclaim policy fails to restore when swinging volume
Product:	OpenShift Container Platform	Reporter:	Dylan Murray <dymurray>
Component:	Migration Tooling	Assignee:	Dylan Murray <dymurray>
Status:	CLOSED ERRATA	QA Contact:	Zhang Cheng <chezhang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	xjiang
Target Milestone:	---
Target Release:	4.2.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-30 04:44:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dylan Murray 2019-10-14 16:12:50 UTC

Description of problem:
Our plugin is supposed to be setting the PV reclaim policy to `retain` whenever `move` is selected. This part is functioning properly, but the original PV definition is passed into the backup instead of the modified one which leaves Velero to restore a PV with the `delete` reclaim policy. This causes velero to change the PVC to provision a new PV.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Have a PV with `Delete` reclaim policy
2. Include PV in migration setting it to `move`
3. Check App data on destination cluster. Check PV that PVC is using

Actual results:
OCP provisions a new PV losing all existing data

Expected results:
Migration should bring original PV definition over to the destination cluster

Additional info:

Comment 1 Dylan Murray 2019-10-15 15:56:03 UTC

https://github.com/fusor/openshift-migration-plugin/pull/31

Comment 2 Dylan Murray 2019-10-17 18:51:41 UTC

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=24126963

Comment 3 Dylan Murray 2019-10-18 13:40:20 UTC

Previous build failed. New one succeeded and was pushed to the errata:

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=24139170

Comment 4 Xin jiang 2019-10-21 11:44:10 UTC

Verified.

Comment 6 errata-xmlrpc 2019-10-30 04:44:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3151