Bug 1761960

Summary:	Upgrading a manager overrides the custom /etc/ovirt-imageio-proxy/ovirt-imageio-proxy.conf file
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Robert McSwain <rmcswain>
Component:	ovirt-imageio-proxy	Assignee:	Vojtech Juranek <vjuranek>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilan Zuckerman <izuckerm>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.3.5	CC:	lsurette, mkalinin, murat.ungor, nsoffer, pelauter, tnisan, vjuranek
Target Milestone:	ovirt-4.4.1	Keywords:	Reopened
Target Release:	---	Flags:	lsvaty: testing_plan_complete-
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-05 07:19:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert McSwain 2019-10-15 17:38:13 UTC

Description of problem:
Upgrading a manager from RHV-M 4.2 to RHV-M 4.3 overrides the custom /etc/ovirt-imageio-proxy/ovirt-imageio-proxy.conf file

Version-Release number of selected component (if applicable):
ovirt-engine-4.3.6.7-0.1.el7.noarch  

How reproducible:
Upgrade from RHV-M 4.2 to RHV-M 4.3 and observe custom changes reset to the defaults

Actual results:
/etc/ovirt-imageio-proxy/ovirt-imageio-proxy.conf is overwritten

Expected results:
Custom /etc/ovirt-imageio-proxy/ovirt-imageio-proxy.conf is recognized and left as-is.

Comment 2 Nir Soffer 2020-04-26 01:09:43 UTC

Should be fixed in ovirt-imageio 2.0 since we replaced the proxy with the daemon.

Comment 3 Nir Soffer 2020-05-13 09:55:39 UTC

This is actually fixed by bug 1826679. The issue is not possible now.

Comment 6 Vojtech Juranek 2020-05-14 09:32:34 UTC

imageio-proxy was deprecated and is removed in 4.4. We don't support automated migration from 4.3 to 4.4. However, in 4.4, imageio provides drop-in configuration (see BZ #1826679), so that user can provide custom changes to the configuration and these changes won't be overwritten during next upgrade as imageio now has it's own config file and will eventually overwrite only this file.

Comment 7 Nir Soffer 2020-05-14 09:53:39 UTC

I think this bug was fixed in 4.4 so it is wrong to close it as WONTFIX.

QE can test the scenario:

1. Customer modify configuration

Create modifes configuration:

$ cat /etc/ovirt-imageio/conf.d/99-customer.conf
# customer configuration
[logger_root]
level = DEBUG

2. Restart ovirt-imageio service

ovirt-imageio daemon should use DEBUG log level now.

3. Upgrade to new version of ovirt-imageio-daemon, or reinstall it

Expected results:
- /etc/ovirt-imageio/conf.d/99-customer.conf is not modified
- /var/log/ovirt-imageio/daemon.log still using DEBUG log level

Regarding 4.3, this will not be fixed in 4.3, since 4.4 will be release
soon.

Installing 4.4 requires new deployment on RHEL 8.2, so customer
configuration on older deployment on RHEL 7.7 host is of course
not migrated to the new setup. But customer can apply the same
configuration change in the new 4.4 deployment.

This was the motivation for introducing drop-in configuration
in bug 1826679.

Comment 8 Ilan Zuckerman 2020-06-02 05:25:25 UTC

Verified on rhv-4.4.1-2
With steps from comment #7
step 3 was reinstalling of ovirt-imageio-daemon

Comment 10 Red Hat Bugzilla 2023-09-14 05:44:35 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days