Bug 1762026 (review2019_libemu)

Summary: Review Request: libemu - The x86 shell-code detection and emulation
Product: [Fedora] Fedora Reporter: Michal Ambroz <rebus>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: extras-orphan, mhroncok, package-review, zbyszek
Target Milestone: ---Flags: zbyszek: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-16 23:17:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1747649, 1766686    

Description Michal Ambroz 2019-10-15 21:23:20 UTC
Spec URL: https://rebus.fedorapeople.org/SPECS/libemu.spec
SRPM URL: https://rebus.fedorapeople.org/SRPMS/libemu-0.2.0-11.20130410gitab48695.fc32.src.rpm

Description:
The libemu is a small library written in C offering basic x86 emulation and
shell-code detection using GetPC heuristics. Intended use is within network
intrusion/prevention detection and honeypots.

Package was retired based on https://bugzilla.redhat.com/show_bug.cgi?id=1634370

This request is to get the package back to rawhide. Package was modified to not generate the python2 subpackage on f31+ epel8+

Here is the scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=38297119

Michal Ambroz

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-10-16 05:59:31 UTC
warning: extra tokens at the end of %endif directive in line 99:  %endif #build_release
warning: extra tokens at the end of %endif directive in line 236:  %endif #with_python2
warning: extra tokens at the end of %endif directive in line 250:  %endif #with_python3
warning: extra tokens at the end of %endif directive in line 304:  %endif #with_python2
warning: extra tokens at the end of %endif directive in line 311:  %endif #with_python3
warning: extra tokens at the end of %endif directive in line 362:  %endif #with_python3

libemu.x86_64: W: incoherent-version-in-changelog 0.2.0-10.20130410gitab48695.1 ['0.2.0-11.20130410gitab48695.fc32', '0.2.0-11.20130410gitab48695']

The spec file is not pretty because of all the accumulated cruft, but I assume you
are not interested in modernization right now. It seems all OK though.

Package is RE-APPROVED.

Comment 2 Miro Hrončok 2019-10-16 06:02:54 UTC
https://pagure.io/releng/issue/8908

Comment 3 Michal Ambroz 2019-10-16 07:59:39 UTC
Thank you guys