Bug 1762693
| Summary: | etckeeper breaks ansible in EPEL8 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Felix Schwarz <fschwarz> |
| Component: | etckeeper | Assignee: | Thomas Moschny <thomas.moschny> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel8 | CC: | alan.christopher.jenkins, spamfaenger, thomas.moschny |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | etckeeper-1.18.10-6.fc31 etckeeper-1.18.10-6.fc30 etckeeper-1.18.12-1.fc30 etckeeper-1.18.12-1.fc31 etckeeper-1.18.12-1.el8 etckeeper-1.18.12-1.el6 etckeeper-1.18.12-1.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-12-10 03:04:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Felix Schwarz
2019-10-17 09:19:23 UTC
Just fyi: I put this patch in my fork (https://src.fedoraproject.org/fork/fschwarz/rpms/etckeeper) and can submit a pull request if you like. Also I can confirm that the patch fixes ansible for me and it seems as if etckeeper is still working fine. This is also a problem for Fedora 31 (basically every version which uses "dnf"). FEDORA-EPEL-2019-dce1c182e6 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-dce1c182e6 FEDORA-2019-fac6c8e0ad has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-fac6c8e0ad In addition to the two updates above, there is the EPEL8 one here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-93760fb3c9 ... and F30 here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9d7322a73b etckeeper-1.18.10-6.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fac6c8e0ad etckeeper-1.18.10-6.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9d7322a73b etckeeper-1.18.10-6.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-93760fb3c9 etckeeper-1.18.10-6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-dce1c182e6 Unfortunately I think I made an error in my previous testing as ansible still does not work 100% for me. Anyway the patches do not cause harm and I think they are just not complete enough. Will try to contact sourcejedi... In https://github.com/sourcejedi/etckeeper/tree/dnf2, sourcejedi made a different approach to solve the issue. Would that work better for you? etckeeper-1.18.10-6.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. etckeeper-1.18.10-6.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. Thanks for picking this up!
I reproduced the problem with that patch. It wasn't especially interesting. (In the *post-commit* call, I used stdout=None. What I needed to use was stdout=open("/dev/null", "wb"))
The more recent patch - the commit from the "dnf2" branch - already avoids this problem. Can we switch to that one?
FEDORA-EPEL-2019-8f350b0237 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-8f350b0237 FEDORA-EPEL-2019-6262a02c16 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6262a02c16 FEDORA-2019-d47ea5ceb0 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d47ea5ceb0 FEDORA-2019-091f76387e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-091f76387e (In reply to Alan Jenkins from comment #15) > The more recent patch - the commit from the "dnf2" branch - already avoids > this problem. Can we switch to that one? I've switched to that patch, and also updated etckeeper to 1.18.12, could you please test it? I installed the F31 build in a VM. It passes the same scenario, that I found the first patch fails at. Thanks. I rebuilt the SRPM in COPR for EPEL8 and was able to run ansible on two machines without problems. etckeeper-1.18.12-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-091f76387e etckeeper-1.18.12-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d47ea5ceb0 etckeeper-1.18.12-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-8f350b0237 etckeeper-1.18.12-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6262a02c16 etckeeper-1.18.12-1.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-d4bfeee795 (In reply to Felix Schwarz from comment #22) > I rebuilt the SRPM in COPR for EPEL8 and was able to run ansible on two > machines without problems. No need to rebuild, there's also an EPEL8 build/update: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-d4bfeee795 . etckeeper-1.18.12-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. etckeeper-1.18.12-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. etckeeper-1.18.12-1.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report. etckeeper-1.18.12-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. etckeeper-1.18.12-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |