Bug 1763702

Summary: wget is ignoring no_proxy environment variable
Product: Red Hat Enterprise Linux 8 Reporter: Francisco Peralta <fperalta>
Component: wgetAssignee: Tomáš Hozza <thozza>
Status: CLOSED ERRATA QA Contact: Ondrej Mejzlik <omejzlik>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 8.0CC: fkrska, mruprich, omejzlik, psklenar, shawn, thozza, toneata
Target Milestone: rcKeywords: Patch, Reproducer, TestCaseProvided, Triaged, ZStream
Target Release: 8.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1772821 (view as bug list) Environment:
Last Closed: 2020-11-04 02:30:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1772821    

Description Francisco Peralta 2019-10-21 11:43:39 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Francisco Peralta 2019-10-21 11:52:43 UTC
Sorry I hit enter to fast..

(In reply to Francisco Peralta from comment #0)
> Description of problem:

wget does not correctly use the no_proxy variable in RHEL 8 
 
> Version-Release number of selected component (if applicable):

wget-1.19.5-7.el8_0.1.x86_64

> How reproducible:

Always.
If using a newer wget 1.20.3 or if using older wget from RHEL 7 I do not reproduce the issue.

> Steps to Reproduce:
 1. $ export http_proxy=http://www.notexisting.com:8080
 2. $ export no_proxy=localhost,.redhat.com
 3. $ wget www.redhat.com

> Actual results:

--2019-10-21 13:09:46--  http://www.redhat.com/
Resolving www.nonexisting.com (www.nonexisting.com)... 192.249.111.222
Connecting to www.nonexisting.com (www.nonexsisting.com)|192.249.111.222|:8080... ^C
 
> Expected results:

--2019-10-21 13:50:42--  http://www.redhat.com/
Resolving www.redhat.com (www.redhat.com)... 2a02:26f0:97:181::d44, 2a02:26f0:97:19d::d44, 23.2.233.53
Connecting to www.redhat.com (www.redhat.com)|2a02:26f0:97:181::d44|:80... failed: Network is unreachable.
Connecting to www.redhat.com (www.redhat.com)|2a02:26f0:97:19d::d44|:80... failed: Network is unreachable.
Connecting to www.redhat.com (www.redhat.com)|23.2.233.53|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://www.redhat.com/en [following]
--2019-10-21 13:50:42--  https://www.redhat.com/en
Connecting to www.redhat.com (www.redhat.com)|23.2.233.53|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: ‘index.html’

index.html                        [ <=>                                           ]  71.39K  --.-KB/s    in 0.04s   

2019-10-21 13:50:42 (1.90 MB/s) - ‘index.html’ saved [73101]

Converting links in index.html... 20-131
Converted links in 1 files in 0.004 seconds.
 
> Additional info:

The issue must have been fixed in the upstream community, I could not find the exact place nor the root cause of introducing it, but I think it's a matter of updating the RHEL 8 version of wget.

Comment 10 Tomáš Hozza 2019-11-07 16:44:29 UTC
During writing a test for the issue, I found a corner case which is still not fixed in upstream. I'll wait for their response first.

For more information, please see https://lists.gnu.org/archive/html/bug-wget/2019-11/msg00011.html

Comment 11 Shawn K. O'Shea 2019-11-13 21:23:01 UTC
The GNU Emacs manual covers this corner case in at least a little more detail. See https://www.gnu.org/software/emacs/manual/html_node/url/Proxies.html

As per your post, correlated with the EMACS manual, if you want the "host" mit.edu to not use the proxy, you would need to add it to no_proxy (so no_proxy=.mit.edu,mit.edu).

I'd really like to see this bug fixed as our local proxy server actually denies requests to proxy internally, so without changing proxy vars (that we've been using for over a decade), wget to our internal websites just doesn't work.

Comment 14 Shawn K. O'Shea 2019-11-15 14:46:15 UTC
Just a few links for extra documentation.

This regression in wget appears to have gone into changes in src/host.c with commit 55d25fc20c0141cb7cb8bd0a6964b81aa0b50124 on 2018-01-07 and was released with wget 1.19.3.
http://git.savannah.gnu.org/cgit/wget.git/commit/?id=fd85ac9cc623847e9d94d9f9241ab34e2c146cbf

This was reported upstream in #53622 (https://savannah.gnu.org/bugs/?53622).

Although not acknowledged in the upstream issue tracker, this appears fixed in upstream commit fd85ac9cc623847e9d94d9f9241ab34e2c146cbf on 2018-10-25.
http://git.savannah.gnu.org/cgit/wget.git/commit/?id=fd85ac9cc623847e9d94d9f9241ab34e2c146cbf

According to git tags in the wget repo, 1.19.5 was release 2018-05-06, so this fix wasn't included until the 1.20 release on 2018-11-13.

Comment 15 Tomáš Hozza 2019-11-21 15:48:37 UTC
So the no_proxy correct behavior in wget is for a longer discussion and since there is no standard, it is impossible to get it completely right. For this reason I decided to continue the discussion and possible changes in upstream, but will backport the current current upstream wget behavior to RHEL-8 in order to solve this pressing customer issue as soon as possible.

Comment 16 Francisco Peralta 2019-11-22 10:09:51 UTC
Thank you Tomás,
 Yes, I think the most important thing now is to make sure the behaviour of no_proxy is again consistent with previous versions.
 Then discussions about what is the standard to use and agree on it can be taken and if then eventually those will be different, it will be announced in release notes in advance and proper way.

Kind Regards,
 Cisco.

Comment 31 errata-xmlrpc 2020-11-04 02:30:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (wget bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4630