Bug 176521
| Summary: | [PATCH] Allow spectool to retry after timeout | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> | ||||||||
| Component: | fedora-rpmdevtools | Assignee: | Ville Skyttä <scop> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 4 | CC: | extras-qa, nphilipp | ||||||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | 1.4-1 | Doc Type: | Enhancement | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2005-12-30 18:17:02 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Ignacio Vazquez-Abrams
2005-12-24 03:38:38 UTC
Created attachment 122569 [details]
spectool retry patch
Hm, I agree that this functionality is desired, but on the other hand, I'd like some more flexibility. This can be already achieved by customizing /etc/wgetrc or ~/.wgetrc or by pointing the WGETRC environment variable to another one for all wget invocations. We could of course install another wgetrc somewhere for spectool use and set the WGETRC environment variable in the script to point to that if spectool requires something else than generic wgetrc's or if it's not desirable to use the "global" one, and/or if/when wget's default options are not good enough for spectool use. Thoughts? I'm not averse to having a specific option set location for Fedora tools, but enforcing it system-wide via /etc/wgetrc or ~/.wgetrc is the wrong idea. Created attachment 122589 [details]
Allow spectool specific wget configuration
Sure. How about something like the attached patch?
I was thinking more along the lines of e.g. /etc/fedora-tools/wgetrc and ~/.fedora-tools/wgetrc, and then any Fedora tool could include that file and benefit from any changes. Works for me if it can be done in a sane backwards compatible way. I wouldn't want to configure the same settings in multiple wgetrc's, the normal /etc/wgetrc and ~/.wgetrc work fine for me. So some kind of a fallback needs to be provided, for example like "if /etc/fedora/wgetrc exists, use it, otherwise use the usual system ones". wget will fall back on the system defaults if $WGETRC isn't defined so I don't see that as a problem. The only "problem" would be the "if /etc/fedora/wgetrc exists" part. In order to preserve backwards compatibility and the possibility to just use the usual system wgetrc's, I imagine we wouldn't be shipping that file. Or if shipped, we need to make sure that it can be just removed locally and future package upgrades won't reinstall it. Agreed on not shipping it. Owning /etc/fedora ought to be enough, and the rest can be in README.spectool. I don't know it should be %ghosted since it makes little sense to futz with the user's configuration that way. Created attachment 122631 [details]
Allow spectool specific wget configuration
Ok, what do you (both) think of this patch? (Contains an unrelated update of
the GPL to the latest available from gnu.org.)
If it works then it works for me. OK with me. I've applied the patch to upstream, it's in spectool-1.0.6. Included in 1.4-1, thanks. |