Bug 1766598

Spec URL: https://atim.fedorapeople.org/for-review/cataclysm-dda.spec
SRPM URL: https://atim.fedorapeople.org/for-review/cataclysm-dda-0.0.9822-2.20191029git5c100d7.fc31.src.rpm

https://copr-be.cloud.fedoraproject.org/results/atim/cataclysm-dda/fedora-31-x86_64/01084344-cataclysm-dda/cataclysm-dda.spec

https://copr-be.cloud.fedoraproject.org/results/atim/cataclysm-dda/fedora-31-x86_64/01084344-cataclysm-dda/cataclysm-dda-0.0.9853-1.20191031git15bd2e1.fc31.src.rpm

https://copr-be.cloud.fedoraproject.org/results/atim/cataclysm-dda/fedora-31-x86_64/01092821-cataclysm-dda/cataclysm-dda.spec

https://copr-be.cloud.fedoraproject.org/results/atim/cataclysm-dda/fedora-31-x86_64/01092821-cataclysm-dda/cataclysm-dda-0.0.9893-1.20191031git15bd2e1.fc31.src.rpm

Package approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License Boost Software License
     Creative Commons Attribution Public License (v3.0) GNU General Public
     License (v2)", "Creative Commons Attribution-ShareAlike Public License
     (v3.0)", "*No copyright* Creative Commons Attribution-ShareAlike
     Public License (v3.0)", "Boost Software License (v1.0)", "*No
     copyright* GNU General Public License (v3)", "Expat License". 3876
     files have unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/cataclysm-dda/review-cataclysm-
     dda/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     cataclysm-dda-data , cataclysm-dda-tiles , cataclysm-dda-tiles-data
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1116160 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: cataclysm-dda-0.0.9822-2.20191029git5c100d7.fc32.x86_64.rpm
          cataclysm-dda-data-0.0.9822-2.20191029git5c100d7.fc32.noarch.rpm
          cataclysm-dda-tiles-0.0.9822-2.20191029git5c100d7.fc32.x86_64.rpm
          cataclysm-dda-tiles-data-0.0.9822-2.20191029git5c100d7.fc32.noarch.rpm
          cataclysm-dda-debuginfo-0.0.9822-2.20191029git5c100d7.fc32.x86_64.rpm
          cataclysm-dda-debugsource-0.0.9822-2.20191029git5c100d7.fc32.x86_64.rpm
          cataclysm-dda-0.0.9822-2.20191029git5c100d7.fc32.src.rpm
cataclysm-dda.x86_64: W: spelling-error %description -l en_US Roguelike -> Rogue like, Rogue-like, Rogelio
cataclysm-dda.x86_64: W: spelling-error %description -l en_US procedurally -> procedural
cataclysm-dda.x86_64: W: dangling-relative-symlink /usr/share/doc/cataclysm-dda/doc/JSON_LOADING_ORDER.md ../data/json/LOADING_ORDER.md
cataclysm-dda.x86_64: W: no-manual-page-for-binary cataclysm
cataclysm-dda-data.noarch: W: no-documentation
cataclysm-dda-data.noarch: E: script-without-shebang /usr/share/cataclysm-dda/json/vehicleparts/turret.json
cataclysm-dda-tiles.x86_64: W: spelling-error Summary(en_US) gfx -> GIF
cataclysm-dda-tiles.x86_64: W: summary-not-capitalized C cataclysm-dda version with gfx and sound
cataclysm-dda-tiles.x86_64: W: spelling-error %description -l en_US gfx -> GIF
cataclysm-dda-tiles.x86_64: W: no-documentation
cataclysm-dda-tiles.x86_64: W: no-manual-page-for-binary cataclysm-tiles
cataclysm-dda-tiles-data.noarch: W: no-documentation
cataclysm-dda-tiles-data.noarch: W: desktopfile-without-binary /usr/share/applications/cataclysm-dda.desktop cataclysm-tiles
cataclysm-dda.src: W: spelling-error %description -l en_US Roguelike -> Rogue like, Rogue-like, Rogelio
cataclysm-dda.src: W: spelling-error %description -l en_US procedurally -> procedural
cataclysm-dda.src:137: W: macro-in-comment %{buildroot}
cataclysm-dda.src:137: W: macro-in-comment %{_datadir}
cataclysm-dda.src:137: W: macro-in-comment %{name}
7 packages and 0 specfiles checked; 1 errors, 17 warnings.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/cataclysm-dda

FEDORA-2019-05d00f5226 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-05d00f5226

FEDORA-2019-5fe5b3454c has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5fe5b3454c

cataclysm-dda-0.D.9984-1.20191128git8d27979.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5fe5b3454c

cataclysm-dda-0.D.9984-1.20191128git8d27979.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-05d00f5226

cataclysm-dda-0.D.9984-1.20191128git8d27979.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

cataclysm-dda-0.D.9984-1.20191128git8d27979.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.