Bug 1767040

Summary: [RFE] Satellite web UI should not show "Full Trace" when someone provides invalid search input
Product: Red Hat Satellite Reporter: Bharati Kailas Shahu <bshahu>
Component: SearchAssignee: Dominik Matoulek <dmatoule>
Status: CLOSED ERRATA QA Contact: Omkar Khatavkar <okhatavk>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.5.0CC: apatel, bkearney, dmatoule, kgaikwad, mhulan
Target Milestone: 6.9.0Keywords: FutureFeature, Triaged
Target Release: UnusedFlags: okhatavk: needinfo+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: tfm-rubygem-foreman_theme_satellite-7.0.1.2-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-21 13:12:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Full Trace Link none

Description Bharati Kailas Shahu 2019-10-30 14:53:11 UTC
1). Proposed title of this feature request

Satellite web UI should not show "Full Trace" when someone provides invalid search input.

2). What is the nature and description of the request?

Currently when someone enters wrong input in search like '   https://satellite.example.com/templates/provisioning_templates?search=&page=1"taiyyib   ' then it fails with error ' invalid value for Integer(): "1\"taiyyib" ' and provides option to check "Full trace"

In the "Full Trace" all the information related to installed gems and ruby package versions is available so it can be misused to find out possible security issues on the satellite server. This is concerning when the Satellite server is exposed over the internet.

Satellite web UI should not show the "Full Trace" error log when we provide any garbage value in page number-based search. It should throw a simple message like "invalid argument" or "Wrong input".


3). How would the customer like to achieve this? (List the functional requirements here)
Remove the stack trace ( "Full Trace") option and throw a simple message like "invalid argument" or "Wrong input"

4).Is there already an existing RFE upstream or in Red Hat Bugzilla?
No

5) . Does the customer have any specific timeline dependencies and which release would they like to target?
No

6). Is the sales team involved in this request and do they have any additional input?
No

7). Would the customer be able to assist in testing this functionality if implemented?
Yes

Comment 4 Dominik Matoulek 2019-11-28 18:56:59 UTC
Created redmine issue https://projects.theforeman.org/issues/28384 from this bug

Comment 5 Bryan Kearney 2020-05-11 16:02:58 UTC
Upstream bug assigned to dmatoule

Comment 6 Bryan Kearney 2020-05-11 16:03:00 UTC
Upstream bug assigned to dmatoule

Comment 7 Bryan Kearney 2020-07-22 16:06:28 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/28384 has been resolved.

Comment 8 Brad Buckingham 2020-11-13 19:13:08 UTC
Fix is in Satellite 6.9 SNAP 1 with foreman-2.3.0-0.7.rc1.el7sat.noarch

Comment 11 Omkar Khatavkar 2020-11-26 14:08:55 UTC
Created attachment 1733755 [details]
Full Trace Link

Comment 21 errata-xmlrpc 2021-04-21 13:12:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.9 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1313

Comment 22 Red Hat Bugzilla 2023-09-15 00:19:24 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days