Bug 1767544
| Summary: | TopIcons Plus fails to display app icons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Porter <tomporterjr> |
| Component: | gnome-shell-extension-topicons-plus | Assignee: | Audrey Yeena Toskin <audrey> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 30 | CC: | audrey, robin.a.meade |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-11-09 05:44:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I created an upstream pull request: https://github.com/phocean/TopIcons-plus/pull/136 Thanks Robin! The upstream extension maintainer no longer actively develops TopIcons Plus, and the GNOME Shell APIs change every major release, so community members submitting patches upstream is basically the only way TopIcons Plus is still usable. I had thought that I would wait for the upstream to test and merge -- phocean never contributes original code but still occasionally merges community contributions -- but they're inactive enough by now that I guess it could be a while...
Robin's commit #0a35713 works well for me in GNOME 3.34.0 on a VM of Fedora Rawhide, so I guess that's what I'm going to build against. See the latest updates here:
https://bodhi.fedoraproject.org/updates/?packages=gnome-shell-extension-topicons-plus
The test package works well. I successfully tested it on Fedora 30 and 31. Thanks Andrew! I tested using the following apps: Skype, Dropbox, telegram-desktop, qbittorrent, Solaar, and Guake. With an X session, all app icons worked. With a Wayland session, all icons worked except Guake, but that's a known issue with Guake. |
Description of problem: TopIcons Plus does not start and the journal shows errors like: gnome-shell[2462]: JS ERROR: TypeError: Main.extensionManager is undefined onTrayIconAdded@/usr/share/gnome-shell/extensions/TopIcons/extension.js:85:1 Version-Release number of selected component (if applicable): 22-5.fc30.20190929.ad2dd1a How reproducible: Very Steps to Reproduce: 1. Update to version 22-5.fc30.20190929.ad2dd1a 2. Restart gnome-shell/relog 3. Note that no app icons appear in the top bar and the journal shows errors Actual results: TopIcons Plus fails to start Expected results: Various app icons are available in the top bar Additional info: Appears that commit is the breaking change: https://github.com/phocean/TopIcons-plus/commit/43f991d1533e8d4002bd25ae6afd8a1568c39b36#diff-06f1274e40de25abda72d812b1cce86a Manually editing extensions.js to the former state, allows TopIcons Plus to launch normally