Bug 1767561

Summary: HCO Operator issues with BareMetalPlatform=false
Product: Container Native Virtualization (CNV) Reporter: Asher Shoshan <ashoshan>
Component: InstallationAssignee: Ryan Hallisey <rhallise>
Status: CLOSED DUPLICATE QA Contact: Irina Gulina <igulina>
Severity: high Docs Contact:
Priority: unspecified    
Version: 2.1.0CC: cnv-qe-bugs, igulina, ncredi, rhallise
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-31 23:21:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Step 1. Create ns in UI
none
Step2. ns created
none
Step 3. In operatorHub, locate HCO, click Install, pick 2.1 version and ns
none
Step 4. Subscription is created
none
Step 5. Create HCO CR, remove extra quotes
none
Step 6. HCO CR created
none
Step 7. Wath pods starting to run in UI
none
Step 8. Watch pods starting to run in CLI
none
Step 9. All pods are up and running in CLI
none
Step 10. All pods are running in UI
none
Step 11. The last one....
none
hco operator log when BareMetalPlatform: "false" none

Description Asher Shoshan 2019-10-31 17:03:26 UTC 
Description of problem:

when BareMetalPlatform=false in HCO cr. HCO operator is not progressing.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Ryan Hallisey 2019-10-31 17:12:11 UTC 
Have the logs from the operator?
Comment 2 Irina Gulina 2019-10-31 22:49:47 UTC 
Created attachment 1631256 [details]
Step 1. Create ns in UI
Comment 3 Irina Gulina 2019-10-31 22:50:32 UTC 
Created attachment 1631257 [details]
Step2. ns created
Comment 4 Irina Gulina 2019-10-31 22:54:47 UTC 
Created attachment 1631258 [details]
Step 3. In operatorHub, locate HCO, click Install, pick 2.1 version and ns
Comment 5 Irina Gulina 2019-10-31 22:55:45 UTC 
Created attachment 1631259 [details]
Step 4. Subscription is created
Comment 6 Irina Gulina 2019-10-31 22:57:50 UTC 
Created attachment 1631260 [details]
Step 5. Create HCO CR, remove extra quotes
Comment 7 Irina Gulina 2019-10-31 22:59:01 UTC 
Created attachment 1631261 [details]
Step 6. HCO CR created
Comment 8 Irina Gulina 2019-10-31 22:59:56 UTC 
Created attachment 1631262 [details]
Step 7. Wath pods starting to run in UI
Comment 9 Irina Gulina 2019-10-31 23:02:00 UTC 
Created attachment 1631263 [details]
Step 8. Watch pods starting to run in CLI
Comment 10 Irina Gulina 2019-10-31 23:05:12 UTC 
Created attachment 1631264 [details]
Step 9. All pods are up and running in CLI
Comment 11 Irina Gulina 2019-10-31 23:08:34 UTC 
Created attachment 1631265 [details]
Step 10. All pods are running in UI
Comment 12 Irina Gulina 2019-10-31 23:10:10 UTC 
Created attachment 1631266 [details]
Step 11. The last one....
Comment 14 Asher Shoshan 2019-11-03 14:10:01 UTC 
Created attachment 1632154 [details]
hco operator log when BareMetalPlatform: "false"
Comment 15 Asher Shoshan 2019-11-03 14:10:57 UTC 
(In reply to Ryan Hallisey from comment #1)
> Have the logs from the operator?

See attached log hco_operator.log.gz
Comment 17 Asher Shoshan 2019-11-03 14:27:59 UTC 
Ryan,

removing the quotes/double-quotes from (BareMetalPlatform: 'false'), seems to solve the issue..

AFAIK, it's ok to quote string values in yaml.
WDYT
Comment 18 Asher Shoshan 2019-11-03 14:41:52 UTC 
I guess it's a boolean value, so the bug is in UI composing the cr.
Irina, pls reopen the bug (with different focus?).
Comment 19 Irina Gulina 2019-11-03 17:15:49 UTC 
>> AFAIK, it's ok to quote string values in yaml.
Yes, if one needs to 
* escape a special char
* force a string value instead of the numeric one, or
* with yes/no to enforce string class instead of true/false class

and a couple of other cases. Otherwise, generally, they are not used. It's in YAML cookbook.

As far as I understand JSON parse takes quoted "false" as a string value, instead of true/false class.  

Anyway, 

The release and installation docs contain the note about quotas: https://github.com/openshift/openshift-docs/pull/17773
The issue itself has been fixed, i.e. the corresponding PR has been merged, it will be in 2.1.1 release: https://github.com/openshift/openshift-docs/pull/17773
Comment 20 Irina Gulina 2019-11-03 17:19:19 UTC 
ops, the last link should be: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/332
Comment 23 Irina Gulina 2019-11-04 11:19:00 UTC 

*** This bug has been marked as a duplicate of bug 1767167 ***