Bug 1767698

Summary: Swift deployment adds /dev/sdX to fstab instead of UUID
Product: Red Hat OpenStack Reporter: Brendan Shephard <bshephar>
Component: openstack-tripleo-heat-templatesAssignee: Christian Schwede (cschwede) <cschwede>
Status: CLOSED ERRATA QA Contact: Gal Amado <gamado>
Severity: medium Docs Contact:
Priority: medium    
Version: 13.0 (Queens)CC: cschwede, gfidente, jjoyce, jschluet, lmarsh, mburns, rurena, slinaber, tvignaud, zaitcev
Target Milestone: z2Keywords: Triaged
Target Release: 16.1 (Train on RHEL 8.2)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-11.3.2-1.20200914170155.29a02c1.el8ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-28 15:36:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Brendan Shephard 2019-11-01 05:35:36 UTC
Description of problem:
When deploying Swift following the best practise guide:
https://access.redhat.com/articles/2745961

It created the entry in /etc/fstab using /dev/sdb instead of the UUID of the block device. This can lead to issues if the assignment changes. For example, a Kernel update has resulted in the internal card reader of a HP server being labelled as /dev/sdb instead of the previous /dev/sdc. Rebooting into the old kernel fixes is.

It seems to only be an issue in fstab as swift.conf refers to /srv/node. So puppet-swift might not be the right place, please feel free to reassign the component as required.

Version-Release number of selected component (if applicable):
puppet-swift-12.4.0-4.el7ost.noarch

How reproducible:
Only if the kernel decides to mix the /dev/sdX devices around

Steps to Reproduce:
1. Deploy as per best practise recommendations above
2. Update kernel
3. Hope it doesn't relabel the disks.

Actual results:
Failure during overcloud update as swift is unable to complete the update.

Expected results:
Device should be added to /etc/fstab by it's UUID as per Linux best practise. 

Additional info:
$ cat etc/fstab 
LABEL=img-rootfs / xfs defaults 0 1
/dev/sdb /srv/node/sdb xfs noatime 0 0

Comment 1 Christian Schwede (cschwede) 2019-12-19 09:21:05 UTC
Looks like a good idea, we should work on this for an upcoming release.

Comment 6 Christian Schwede (cschwede) 2020-08-21 16:58:32 UTC
Proposed upstream patch: https://review.opendev.org/#/c/747444/

Comment 14 errata-xmlrpc 2020-10-28 15:36:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4284