Bug 1767824

Summary:	multiple workers start the same retirement when retirement date is reached
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Automate	Assignee:	Tina Fitzgerald <tfitzger>
Status:	CLOSED ERRATA	QA Contact:	Ganesh Hubale <ghubale>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	medium
Version:	5.10.8	CC:	dmetzger, fdewaley, ghubale, gmccullo, mkanoor, obarenbo, simaishi, tfitzger
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.11.1	Flags:	simaishi: cfme-5.11.z+
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	5.11.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1748353	Environment:
Last Closed:	2019-12-13 00:35:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:	1748353
Bug Blocks:

Comment 2 CFME Bot 2019-11-01 19:33:01 UTC

New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/541bf15ec244bc033bbdc7b3ca40c710ceec74b4
commit 541bf15ec244bc033bbdc7b3ca40c710ceec74b4
Author:     Brandon Dunne <bdunne>
AuthorDate: Tue Aug 20 16:36:52 2019 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Tue Aug 20 16:36:52 2019 -0400

    Merge pull request #19143 from lfu/dup_service_retire_request_18558

    Service retirement request should be per region.

    (cherry picked from commit 3ab4626c51447481724d8b720c9e83c0ee788a9d)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767824

 app/models/miq_schedule_worker/jobs.rb | 1 +
 app/models/retirement_manager.rb | 7 +-
 spec/models/retirement_manager_spec.rb | 9 +-
 3 files changed, 14 insertions(+), 3 deletions(-)

Comment 3 Ganesh Hubale 2019-11-12 07:33:44 UTC

Fixed!

Verified on version: 5.11.1.0.20191105221526_f1764d4

Observations:
=============

1] RetirementManager.check ran on both appliances in region

Appliance 1
===========
[----] I, [2019-11-12T02:16:30.936245 #3308:2ac37ddc05bc]  INFO -- : MIQ(MiqGenericWorker::Runner#get_message_via_drb) Message id: [702], MiqWorker id: [55], Zone: [default], Role: [], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [RetirementManager.check], Timeout: [600], Priority: [90], State: [dequeue], Deliver On: [], Data: [], Args: [], Dequeued in: [3.792557964] seconds
[----] I, [2019-11-12T02:26:35.336137 #3308:2ac37ddc05bc]  INFO -- : MIQ(MiqGenericWorker::Runner#get_message_via_drb) Message id: [836], MiqWorker id: [55], Zone: [default], Role: [], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [RetirementManager.check], Timeout: [600], Priority: [90], State: [dequeue], Deliver On: [], Data: [], Args: [], Dequeued in: [6.345495128] seconds

Appliance 2
===========
[----] I, [2019-11-12T02:26:28.992944 #7263:2b1d8f2ca5c4]  INFO -- : MIQ(MiqQueue.put) Message id: [836],  id: [], Zone: [default], Role: [], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [RetirementManager.check], Timeout: [600], Priority: [90], State: [ready], Deliver On: [], Data: [], Args: []
[----] I, [2019-11-12T02:26:28.998207 #7263:2b1d8f2ca5c4]  INFO -- : MIQ(MiqQueue.put) Message id: [837],  id: [], Zone: [New_Zone], Role: [], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [RetirementManager.check], Timeout: [600], Priority: [90], State: [ready], Deliver On: [], Data: [], Args: []
[----] I, [2019-11-12T02:26:29.002325 #7263:2b1d8f2ca5c4]  INFO -- : MIQ(MiqQueue.put) Message id: [838],  id: [], Zone: [], Role: [], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [RetirementManager.check_per_region], Timeout: [600], Priority: [90], State: [ready], Deliver On: [], Data: [], Args: []
[----] I, [2019-11-12T02:26:32.483681 #7218:2b1d8f2ca5c4]  INFO -- : MIQ(MiqGenericWorker::Runner#get_message_via_drb) Message id: [837], MiqWorker id: [45], Zone: [New_Zone], Role: [], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [RetirementManager.check], Timeout: [600], Priority: [90], State: [dequeue], Deliver On: [], Data: [], Args: [], Dequeued in: [3.488189092] seconds


2] Retire request for service is only one from which it was created and retired

[----] I, [2019-11-12T02:16:30.368467 #7218:2b1d8f2ca5c4]  INFO -- : Setting retirement requester of cat_item to 1.
[----] I, [2019-11-12T02:26:32.498604 #7218:2b1d8f2ca5c4]  INFO -- : Setting retirement requester of cat_item to 1.

Comment 5 errata-xmlrpc 2019-12-13 00:35:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:4201