Bug 1768346

Summary: [sriov] 'nodeSelector' should be replaced by 'configDaemonNodeSelector' in CRD sriovoperatorconfigs
Product: OpenShift Container Platform Reporter: zhaozhanqi <zzhao>
Component: NetworkingAssignee: zenghui.shi <zshi>
Networking sub component: openshift-sdn QA Contact: zhaozhanqi <zzhao>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: high    
Version: 4.3.0   
Target Milestone: ---   
Target Release: 4.3.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-23 11:10:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description zhaozhanqi 2019-11-04 06:58:06 UTC
Description of problem:
In crd sriovoperatorconfigs.sriovnetwork.openshift.io, it shows 'nodeSelector':

            properties:
              enableInjector:
                description: Flag to control whether the network resource injector
                  webhook shall be deployed
                type: boolean
              enableOperatorWebhook:
                description: Flag to control whether the operator admission controller
                  webhook shall be deployed
                type: boolean
              nodeSelector:
                additionalProperties:
                  type: string
                description: NodeSelector selects the nodes to be configured
                type: object
            type: object


but if 'nodeSelector", it did not be taken effected. when updating to 'configDaemonNodeSelector', it can works well.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. install the sriov operator
2. check the default CRD sriovoperatorconfigs.sriovnetwork.openshift.io
  oc get crd sriovoperatorconfigs.sriovnetwork.openshift.io -o yaml
3.

Actual results:

step 2:
show 'nodeSelector'

Expected results:

Should be 'configDaemonNodeSelector'

Additional info:

Comment 2 zhaozhanqi 2019-11-11 05:25:32 UTC
Verified this bug 

            description: SriovOperatorConfigSpec defines the desired state of SriovOperatorConfig
            properties:
              configDaemonNodeSelector:
                additionalProperties:
                  type: string
                description: NodeSelector selects the nodes to be configured
                type: object
              enableInjector:
                description: Flag to control whether the network resource injector
                  webhook shall be deployed
                type: boolean

Comment 4 errata-xmlrpc 2020-01-23 11:10:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062