Bug 1768640

Summary:	Review Request: mozjs68 - JavaScript interpreter and libraries
Product:	[Fedora] Fedora	Reporter:	František Zatloukal <fzatlouk>
Component:	Package Review	Assignee:	Kalev Lember <klember>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	klember, package-review
Target Milestone:	---	Flags:	klember: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-24 23:13:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description František Zatloukal 2019-11-04 21:17:35 UTC

SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/mozjs68/fedora-31-x86_64/01086017-mozjs68/mozjs68.spec
SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/mozjs68/fedora-31-x86_64/01086017-mozjs68/mozjs68-68.2.0-1.fc31.src.rpm

Description: 
SpiderMonkey is the code-name for Mozilla Firefox's C++ implementation of JavaScript. It is intended to be embedded in other applications that provide host environments for JavaScript.

It's based on mozjs60 package: https://src.fedoraproject.org/rpms/mozjs60

New GNOME Shell is going to require this: https://gitlab.gnome.org/GNOME/gjs/issues/270

Because of:
BuildRequires:  python2-devel
BuildRequires:  python2-six

It requires Python 2 Exception from FESCO, I'll submit FESCO ticket and post link here soon.

Comment 1 František Zatloukal 2019-11-04 21:29:47 UTC

FESCO Python 2 Exception request: https://pagure.io/fesco/issue/2264

Comment 2 František Zatloukal 2019-11-05 21:11:46 UTC

SRPM: https://copr-be.cloud.fedoraproject.org/results/frantisekz/mozjs68/fedora-rawhide-x86_64/01087160-mozjs68/mozjs68-68.2.0-1.fc32.src.rpm
SPEC: https://copr-be.cloud.fedoraproject.org/results/frantisekz/mozjs68/fedora-rawhide-x86_64/01087160-mozjs68/mozjs68.spec

Updated to run tests with Python 3, still build requires python2-devel.

Comment 3 Kalev Lember 2019-11-06 11:55:54 UTC

This looks good to me, thanks! Not doing a full review as this is essentially just an update for an existing package.

Parallel installability seems to be done correctly so nothing should conflict with existing mozjs52 and mozjs60 packages. Package naming is also correct for parallel installable packages.

APPROVED (but please wait for the fesco python2 use exception before requesting the repo and importing)

Comment 4 Gwyn Ciesla 2019-11-12 14:34:22 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mozjs68