Bug 1768693
| Summary: | Subversion-kde kwallet integration broken | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Phil O <rhbugs> |
| Component: | subversion | Assignee: | Joe Orton <jorton> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 31 | CC: | gemilg, jorton, vanmeeuwen+fedora |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | subversion-1.12.2-3.fc30 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-01-22 01:14:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Phil O
2019-11-05 02:15:32 UTC
Is there a kwalletd service which should be running? I'm not a KDE user and am not sure how this works. Yes, there is: $ ps -ef | grep wallet phil 2191 1 0 07:04 ? 00:00:00 /usr/bin/kwalletd5 --pam-login 5 3 I'm wondering if the difference is that now the d-bus service is called kwalletd5 instead of kwalletd? See below. But this may have been the same in Fedora 30 - not sure. $ pwd /usr/share/dbus-1/services $ more org.kde.kwalletd5.service [D-BUS Service] Name=org.kde.kwalletd5 Exec=/usr/bin/kwalletd5 Ignore my last comment - F30 was the same. But I do note that F31 only has this: /usr/share/kservices5/kwalletd5.desktop while F30 had 2 kde services: /usr/share/kservices5/kwalletd.desktop /usr/share/kservices5/kwalletd5.desktop Unfortunately I tried adding kwalletd.desktop and it didn't help. The problem is solely in the spec file, as it has never been updated for KF5, so it always builds kde4 support into the package. The below patch to the spec file makes it recognize that we are on a KDE 5 system. Unfortunately, I now see "org.kde.kwindowsystem: Could not find any platform plugin" on every svn action, but at least kwallet is able to cache passwords again, which is a step in the right direction. @Joe Orton - please apply.
--- subversion.spec.orig 2019-07-25 01:12:25.000000000 -0700
+++ subversion.spec 2020-01-01 19:10:03.889613273 -0800
@@ -142,7 +142,7 @@
%package kde
Summary: KDE Wallet support for Subversion
Requires: subversion%{?_isa} = %{version}-%{release}
-BuildRequires: kdelibs-devel >= 4.0.0
+BuildRequires: qt5-devel >= 5.0.0, kf5-kwallet-devel, kf5-ki18n-devel, kf5-kcoreaddons-devel
%description kde
The subversion-kde package adds support for storing Subversion
@@ -249,7 +249,7 @@
--with-junit=%{_prefix}/share/java/junit.jar \
%endif
%if %{with kwallet}
- --with-kwallet=%{_includedir}/kde4:%{_libdir}/kde4/devel \
+ --with-kwallet=%{_includedir}:%{_libdir} \
%endif
%if %{with bdb}
--with-berkeley-db \
Package: subversion-1.12.2-3.fc32 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1426443 Package: subversion-1.12.2-3.fc31 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1426517 FEDORA-2020-389c044dc4 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-389c044dc4 Thanks Phil - I've pushed this to the update above. Please test and confirm the fix. subversion-1.12.2-3.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-389c044dc4 *** Bug 1788465 has been marked as a duplicate of this bug. *** Updated RPM works for me, thanks! subversion-1.12.2-3.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. Package: subversion-1.12.2-3.fc30 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1428705 Looks like package for F30 also works fine, thanks. subversion-1.12.2-3.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-dc93756dc3 subversion-1.12.2-3.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. |