Bug 1768956
| Summary: | Include info about flow_dissector eBPF programs (per net name space) | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Jiri Benc <jbenc> |
| Component: | sos | Assignee: | Pavel Moravec <pmoravec> |
| Status: | CLOSED ERRATA | QA Contact: | Miroslav Hradílek <mhradile> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 8.2 | CC: | agk, bmr, mhradile, plambri, sbradley |
| Target Milestone: | rc | Keywords: | OtherQA |
| Target Release: | 8.0 | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | sos-3.8-2.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-04-28 17:01:57 UTC | Type: | Feature Request |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jiri Benc
2019-11-05 16:30:53 UTC
(In reply to Jiri Benc from comment #0) > Please run 'bpftool net' in each net name space. Three questions: Q1) So a bash code for this would be: for space in $(ip netns | awk '{ print $1 }'); do # 'awk' just to trim namespace only ip netns exec $space bpftool net # call and collect this cmd output done ? Q2) Thinking about possible implementation (if this shall go to kernel or networking plugin), can we rely on "ip netns" returning the same list like "ls /var/run/netns" ? Q3) And in general: does bpftool belong rather to kernel or networking? I.e. where sosreport users would rather search for the command outputs - in kernel plugin or networking plugin? Currently we call it from kernel plugin but "per networking namespace" sounds more like networking - but then we would call the same tool once from kernel and once from networking? Or to move all calls of the tool to networking plugin? Ad Q3: with 'bpftool net' added, the command is now a weird mix of kernel general and networking. I would say that the current data captured by bpftool belong to the kernel (where they currently are) and 'bpftool net' belongs to networking. Is that okay?
Ad Q1 and Q2: there are already several commands run per netns in plugins/networking.py:
for namespace in out_ns:
ns_cmd_prefix = cmd_prefix + namespace + " "
self.add_cmd_output([
ns_cmd_prefix + "ip address show",
ns_cmd_prefix + "ip route show table all",
ns_cmd_prefix + "iptables-save",
ns_cmd_prefix + "netstat %s -neopa" % self.ns_wide,
ns_cmd_prefix + "netstat -s",
ns_cmd_prefix + "netstat %s -agn" % self.ns_wide
])
I guess 'bpftool net' can be just added there?
(In reply to Jiri Benc from comment #2) > I guess 'bpftool net' can be just added there? And to the non-netns section, too, to cover the root net name space (and the cases where name spaces are disabled). Thanks for prompt feedback, upstream PR pending: https://github.com/sosreport/sos/pull/1874 Hi, would you mind to verify this BZ once a candidate build is available (probably still in 8.2 timeframe)? (In reply to Pavel Moravec from comment #5) > would you mind to verify this BZ once a candidate build is available > (probably still in 8.2 timeframe)? No problem, just point me to the build you want me to test. (In reply to Jiri Benc from comment #6) > (In reply to Pavel Moravec from comment #5) > > would you mind to verify this BZ once a candidate build is available > > (probably still in 8.2 timeframe)? > > No problem, just point me to the build you want me to test. Ahoj, here you are - thanks in advance for testing! A yum repository for the build of sos-3.8-2.el8 (task 25733431) is available at: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.8/2.el8/ You can install the rpms locally by putting this .repo file in your /etc/yum.repos.d/ directory: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.8/2.el8/sos-3.8-2.el8.repo RPMs and build logs can be found in the following locations: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.8/2.el8/noarch/ The full list of available rpms is: http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.8/2.el8/noarch/sos-3.8-2.el8.src.rpm http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.8/2.el8/noarch/sos-3.8-2.el8.noarch.rpm http://brew-task-repos.usersys.redhat.com/repos/official/sos/3.8/2.el8/noarch/sos-audit-3.8-2.el8.noarch.rpm Build output will be available for the next 21 days. See bug 1721779 comment 17 for the test results. Looks okay. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:1900 |