Bug 1769927

Summary:	Image Registry Operator Allows Edits to Registry Deployment
Product:	OpenShift Container Platform	Reporter:	Adam Kaplan <adam.kaplan>
Component:	Image Registry	Assignee:	Ricardo Maraschini <rmarasch>
Status:	CLOSED ERRATA	QA Contact:	Wenjing Zheng <wzheng>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.1.z	CC:	aos-bugs, bparees, fshaikh, mfuruta, obulatov, rh-container, rmarasch, wewang
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-13 21:52:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Kaplan 2019-11-07 17:51:50 UTC

Description of problem:
A cluster admin can make arbitrary changes to the image registry's deployment, and the image registry operator will leave these changes in place as long as other configuration has not changed.

Version-Release number of selected component (if applicable): 4.1.z


How reproducible: Always


Steps to Reproduce:
1. `oc edit deployment image-registry -n openshift-image-registry`
2. Add an environment variable to the pod template spec - ex: name: FOO, value: BAR
3. Wait for the registry deployment to roll out

Actual results:
Added environment variable is present in the image registry pod.


Expected results:
Image registry operator undoes the edit to the pod template spec, and when rollouts complete the registry pods do not contain the added environment variable.


Additional info:

Comment 1 Ben Parees 2019-11-07 21:49:07 UTC

at a minimum these changes should be getting stomped on our next sync/reconcile loop (not sure what the interval is on that these days).  if they are not, that's definitely a bug.

Comment 3 Oleg Bulatov 2020-02-03 10:55:35 UTC

The pull request is merged.

Comment 5 Wenjing Zheng 2020-02-07 09:40:08 UTC

Verified on 4.4.0-0.nightly-2020-02-06-230833, the changes made in image-registry deployment will be reverted.

Comment 7 errata-xmlrpc 2020-05-13 21:52:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581