Bug 1770022

Summary:	[RFE] Issue with VM reconfiguration dialog (adding networks) after recent upgrade
Product:	Red Hat CloudForms Management Engine	Reporter:	Tuan <tuado>
Component:	UI - OPS	Assignee:	Martin Povolny <mpovolny>
Status:	CLOSED NOTABUG	QA Contact:	Niyaz Akhtar Ansari <nansari>
Severity:	high	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.10.8	CC:	bmidwood, dmetzger, greartes, hkataria, jhardy, lavenel, mfeifer, mpovolny, mshriver, obarenbo
Target Milestone:	GA	Keywords:	RFE, TestOnly, ZStream
Target Release:	5.12.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1788564 1788566 (view as bug list)		Environment:
Last Closed:	2020-03-20 15:45:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Feature
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1788564, 1788566

Description Tuan 2019-11-07 22:34:37 UTC

Description of problem:

The "Network Adapters" reconfiguration feature has a button "add networks" which shows the whole networks/vlans list.
That is not acceptable, this makes the "vm reconfiguration" button very admin-only.

Telefonica is using CF 4.5 in its product Managed Cloud.
It is a single region deployment.

We are currently on a process to upgrade from CF 4.5 to CF 4.7 for both DEVELOPMENT and PRODUCTION environments.
We are just starting with DEVELOPMENT first.

There are a lot of integrations for CF in this customer. (RH IdM, CMDB, PHPIPAM, more).

One thing that is bothering CU is the VM Reconfiguration menu.
In CF 4.7, there is a new addition "Network Adapters" which while good, it poses a problem to them.

In Managed Cloud we are using Tenancy, specifically one CF Project per "Telefonica's Customer"
A Managed Cloud Tenant: CF Child Project + CF Idm Group coming from RH IdM + CMDB

On PHPIPAM each Managed Cloud TENANT has its own networks. (stored in a custom attribute, alongside the port-group.
Also there are network types (BACKEND/MPLS/INTERNET/GESTION) (GESTION means Management in Spanish).
This is a feature of PHPIPAM integration with Managed Cloud.
CF has a single role permission "vm reconfiguration" which includes serveral operations that are bundled together.

Since we cannot customize the list given by the button "add network" (Opened RHBZ #1768602),one might what to not to give the user the ability to reconfigure vm networks... but that is not even possible. (I updated my previous RHBZ #1571983).

This affects CU also with disks (RHBZ #1573266) but is not as severe as the network issue.

So, both not give the permission (and still permitting cpu and ram reconfiguration) is not possible and customizing the list of networks seems to also not be possible.

Version-Release number of selected component (if applicable):
5.10.11

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

Comment 2 dmetzger 2019-11-20 20:16:10 UTC

Github Issue: https://github.com/ManageIQ/manageiq-ui-classic/issues/6422

Comment 3 Martin Povolny 2019-12-04 07:13:15 UTC

Final solution is here:

https://github.com/ManageIQ/manageiq-ui-classic/pull/6469
https://github.com/ManageIQ/manageiq/pull/19566

Comment 6 CFME Bot 2020-01-09 13:41:49 UTC

New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/5650882f0e1dbca1e8f0b10b837dfcd62053b497
commit 5650882f0e1dbca1e8f0b10b837dfcd62053b497
Author:     Martin Povolny <mpovolny>
AuthorDate: Wed Jan  8 09:37:10 2020 -0500
Commit:     Martin Povolny <mpovolny>
CommitDate: Wed Jan  8 09:37:10 2020 -0500

    Reconfigure: use detailed RBAC features

    backport of https://github.com/ManageIQ/manageiq-ui-classic/pull/6469

    fixes https://bugzilla.redhat.com/show_bug.cgi?id=1770022

 app/controllers/miq_request_controller.rb | 2 +-
 app/controllers/mixins/actions/vm_actions/reconfigure.rb | 66 +-
 app/helpers/application_helper/button/vm_reconfigure.rb | 2 +-
 app/helpers/application_helper/button/vm_reconfigure_multiple.rb | 5 +
 app/helpers/application_helper/toolbar/template_clouds_center.rb | 9 -
 app/helpers/application_helper/toolbar/vm_infras_center.rb | 1 +
 app/helpers/application_helper/toolbar/x_template_cloud_center.rb | 5 -
 app/views/vm_common/_reconfigure.html.haml | 202 +-
 spec/helpers/application_helper/buttons/vm_reconfigure_spec.rb | 5 +
 spec/shared/helpers/application_helper_buttons.rb | 4 +-
 10 files changed, 159 insertions(+), 142 deletions(-)

Comment 7 CFME Bot 2020-01-17 20:26:01 UTC

New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/0536bd9350cac30c6a18f444f969a2a5eae779cd
commit 0536bd9350cac30c6a18f444f969a2a5eae779cd
Author:     Martin Povolny <mpovolny>
AuthorDate: Wed Jan  8 09:37:10 2020 -0500
Commit:     Martin Povolny <mpovolny>
CommitDate: Wed Jan  8 09:37:10 2020 -0500

    Reconfigure: use detailed RBAC features

    backport of https://github.com/ManageIQ/manageiq-ui-classic/pull/6469

    fixes https://bugzilla.redhat.com/show_bug.cgi?id=1770022

 app/controllers/miq_request_controller.rb | 2 +-
 app/controllers/mixins/actions/vm_actions/reconfigure.rb | 106 +-
 app/helpers/application_helper/button/vm_reconfigure.rb | 2 +-
 app/helpers/application_helper/button/vm_reconfigure_multiple.rb | 5 +
 app/helpers/application_helper/toolbar/template_clouds_center.rb | 9 -
 app/helpers/application_helper/toolbar/vm_infras_center.rb | 1 +
 app/helpers/application_helper/toolbar/x_template_cloud_center.rb | 5 -
 app/views/vm_common/_reconfigure.html.haml | 203 +-
 spec/helpers/application_helper/buttons/vm_reconfigure_spec.rb | 5 +
 spec/shared/helpers/application_helper_buttons.rb | 4 +-
 10 files changed, 161 insertions(+), 181 deletions(-)