Bug 1770235

Summary: perl-DBD-Pg tests failing due to rebase of libpq 12 and PostgreSQL server 12
Product: Red Hat Enterprise Linux 8 Reporter: Honza Horak <hhorak>
Component: perl-DBD-PgAssignee: perl-maint-list
Status: CLOSED CURRENTRELEASE QA Contact: RHEL CS Apps Subsystem QE <rhel-cs-apps-subsystem-qe>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.1CC: bnater, jorton, kanderso, ppisar
Target Milestone: rcKeywords: Patch, Reproducer, Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-DBD-Pg-3.7.4-3.el8_1 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1772373 1772805 (view as bug list) Environment:
Last Closed: 2020-04-16 09:38:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1772822    
Bug Blocks: 1749461, 1768846    
Attachments:
Description Flags
Upstream fix ported to DBD-Pg-3.7.4 none

Description Honza Horak 2019-11-08 14:39:21 UTC 
This bug was initially created as a copy of Bug #1768846

Description of problem:

* Tests /CoreOS/perl-DBD-Pg/Sanity/upstream-tests fail with the rebased libpq done for rhel-8.1.1.

* After talking to ppisar, it looks like the tests were fixed upstream (see https://bugzilla.redhat.com/show_bug.cgi?id=1768846#c5) and it looks like a good idea to fix this together with delivering postgresql:12 stream (tracked in bz#1721822) + libpq rebase in rhel-8.1.1 (tracked in bz#1749461)

* We still would like to keep bz#1768846 opened for libpq, because it still looks important enough for more investigation, but we're so far convinced the changes in that library do not change ABI, most probably just a slight change in behavior that perl-DBD-pg depended on changed, which should be not relevant nor visible for users.

How reproducible:
Always

Steps to Reproduce:
1. run tests for perl-DBD-Pg with the libpq-12.0 (/CoreOS/perl-DBD-Pg/Sanity/upstream-tests)

Actual results:
4 tests in 03dbmethod.t fails


Expected results:
No fail


Additional info:
see https://bugzilla.redhat.com/show_bug.cgi?id=1768846#c5
Comment 1 Honza Horak 2019-11-08 14:45:09 UTC 
Setting qa_test_coverage+ because the tests already exist.
Comment 4 Petr Pisar 2019-11-11 09:30:13 UTC 
Created attachment 1634798 [details]
Upstream fix ported to DBD-Pg-3.7.4
Comment 5 Petr Pisar 2019-11-11 09:32:40 UTC 
We have perl-DBD-Pg twice in RHEL-8. Once as a non-modular package in BaseOS and once as a modular package of perl-DBD-Pg:3.7 stream in AppStream. We need to fix both of them.
Comment 8 Petr Pisar 2019-11-14 09:24:19 UTC 
There is also a request to pass perl-DBD-Pg tests against PostreSQL 12 server. As the server removes some features and a perl-DBD-Pg library uses them and the tests checks for them, it necessary to apply additional seven patches. These patches preserve perl-DBD-Pg API and all tests pass against PostregreSQL server 9.6, 10, and 12. I will include them referring to this bug report.
Comment 24 Petr Pisar 2019-11-18 16:28:42 UTC 
This is a buildroot-only package. And on pp64le only. It does not need an erratum.